linux-kernel - Re: [PATCH v3 1/1] i2c: Set pinctrl recovery info to device pinctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4344f575-65f5-2fde-e2d5-3dd5a18d13cb@amazon.com>
Date:   Tue, 20 Dec 2022 19:07:51 +0200
From:   "Hawa, Hanna" <hhhawa@...zon.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
CC:     <wsa@...nel.org>, <linus.walleij@...aro.org>,
        <linux-i2c@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-gpio@...r.kernel.org>, <dwmw@...zon.co.uk>,
        <benh@...zon.com>, <ronenk@...zon.com>, <talel@...zon.com>,
        <jonnyc@...zon.com>, <hanochu@...zon.com>, <farbere@...zon.com>,
        <itamark@...zon.com>
Subject: Re: [PATCH v3 1/1] i2c: Set pinctrl recovery info to device pinctrl



On 12/20/2022 12:53 PM, Andy Shevchenko wrote:
>> Signed-off-by: Hanna Hawa <hhhawa@...zon.com>
> > The same comment about changelog. Place it in the correct position.

Will be fixed.

> 
>> Change Log v2->v3:
>> - Add API to get the device pinctrl
>> - Make the i2c init recovery to get the device pins
>>
>> Change Log v1->v2:
>> - set the rinfo->pinctrl to dev->pins->p instead calling
>>    devm_pinctrl_get()
>> ---
> 
>>   include/linux/pinctrl/devinfo.h | 11 +++++++++++
> 
> This should be a separate patch.

Sure, will move and create cover letter with the change log.

> 
> ...
> 
>> +static inline struct pinctrl *dev_pinctrl(struct device *dev)
>> +{
>> +     return dev->pins && dev->pins->p ? dev->pins->p : NULL;
> 
> GCC supports Elvis, you can use it to simplify the above.

How you suggest to simplify this?
I can use 'return dev->pins ? dev->pins->p ?: dev->pins->p : NULL;'

> 
>> +}
> 
> --
> With Best Regards,
> Andy Shevchenko
> 
>