linux-kernel - Re: [PATCH 2/2] ACPI: x86: s2idle: Stop using AMD specific codepath for Rembrandt+

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <fb729a11-46e4-4aab-bfa5-42afca476785@fanf.eu>
Date:   Tue, 20 Dec 2022 17:54:04 +0000
From:   "francois@...f.eu" <francois@...f.eu>
To:     mario.limonciello@....com
Cc:     Shyam-sundar.S-k@....com, anson.tsao@....com, ben@...eng.me,
        bilkow@...anota.com, lenb@...nel.org, linux-acpi@...r.kernel.org,
        linux-kernel@...r.kernel.org, paul@...pog.com,
        philipp.zabel@...il.com, rafael.j.wysocki@...el.com,
        rafael@...nel.org, stable@...r.kernel.org
Subject: Re: [PATCH 2/2] ACPI: x86: s2idle: Stop using AMD specific codepath for Rembrandt+

Am Thu, Dec 15, 2022 at 01:16:16PM -0600 schrieb Mario Limonciello:
> After we introduced a module parameter and quirk infrastructure for  > picking the Microsoft GUID over the SOC vendor GUID we discovered >
that lots and lots of systems are getting this wrong. > > The table
continues to grow, and is becoming unwieldy. > > We don't really have
any benefit to forcing vendors to populate the > AMD GUID. This is just
extra work, and more and more vendors seem > to mess it up. As the
Microsoft GUID is used by Windows as well, > it's very likely that it
won't be messed up like this. > > So drop all the quirks forcing it and
the Rembrandt behavior. This > means that Cezanne or later effectively
only run the Microsoft GUID > codepath with the exception of HP
Elitebook 8*5 G9. > > Fixes: fd894f05cf30 ("ACPI: x86: s2idle: If a new
AMD _HID is missing assume Rembrandt") > Cc: stable@...r.kernel.org #
6.1 > Reported-by: Benjamin Cheng <ben@...eng.me> > Reported-by:
bilkow@...anota.com > Reported-by: Paul <paul@...pog.com> > Link:
https://gitlab.freedesktop.org/drm/amd/-/issues/2292 > Link:
https://bugzilla.kernel.org/show_bug.cgi?id=216768 > Signed-off-by:
Mario Limonciello <mario.limonciello@....com> Tested-by: François ARMAND <francois@...f.eu>
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2307

Regards - and thanks for the help Mario!
François