[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y6IKit5XMcSLBgpO@smile.fi.intel.com>
Date: Tue, 20 Dec 2022 21:18:34 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: "Hawa, Hanna" <hhhawa@...zon.com>
Cc: wsa@...nel.org, linus.walleij@...aro.org,
linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-gpio@...r.kernel.org, dwmw@...zon.co.uk, benh@...zon.com,
ronenk@...zon.com, talel@...zon.com, jonnyc@...zon.com,
hanochu@...zon.com, farbere@...zon.com, itamark@...zon.com
Subject: Re: [PATCH v3 1/1] i2c: Set pinctrl recovery info to device pinctrl
On Tue, Dec 20, 2022 at 07:07:51PM +0200, Hawa, Hanna wrote:
> On 12/20/2022 12:53 PM, Andy Shevchenko wrote:
...
> > > +static inline struct pinctrl *dev_pinctrl(struct device *dev)
> > > +{
> > > + return dev->pins && dev->pins->p ? dev->pins->p : NULL;
> >
> > GCC supports Elvis, you can use it to simplify the above.
>
> How you suggest to simplify this?
Using Elvis operator, which is ?:.
> I can use 'return dev->pins ? dev->pins->p ?: dev->pins->p : NULL;'
Have you even try to compile this?
> > > +}
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists