linux-kernel - Re: [PATCH] f2fs: maintain discard in separated file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20221221040747.42162-1-frank.li@vivo.com>
Date:   Wed, 21 Dec 2022 12:07:47 +0800
From:   Yangtao Li <frank.li@...o.com>
To:     jaegeuk@...nel.org, chao@...nel.org
Cc:     linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] f2fs: maintain discard in separated file

Dear Jaegeuk,

>> This patch moves discard related code from segment.c into discard.c 
>> since discard is independent feature, and it's better to maintain them 
>> in separated place.
>> 
>> There is no functionality change.
> 
> Please check Jaegeuk's comments on similar patch:

> https://lore.kernel.org/linux-f2fs-devel/20180426160819.GI68594@jaegeuk-macbookpro.roam.corp.google.com/

How about to pick Chao' patch?

Discard is a relatively independent feature, maybe we can move it to an independent position.
And for systems that do not support discard, use CONFIG_F2FS_DISACRD=n to cut this part of the code?

Thx,
Yangtao