linux-kernel - Re: [PATCH 0/8] Clean up and refinement for maple tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y6KRuqh+V1Z/I+ji@vernon-pc>
Date:   Wed, 21 Dec 2022 13:03:47 +0800
From:   Vernon Yang <vernon2gm@...il.com>
To:     Liam Howlett <liam.howlett@...cle.com>
Cc:     "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "maple-tree@...ts.infradead.org" <maple-tree@...ts.infradead.org>
Subject: Re: [PATCH 0/8] Clean up and refinement for maple tree

On Tue, Dec 20, 2022 at 03:19:08PM +0000, Liam Howlett wrote:
> * Vernon Yang <vernon2gm@...il.com> [221220 09:09]:
> > Hello,
> >
> > This patchset clean up and refinement some maple tree code, a few small
> > changes make the code easier to understand and for better readability.
>
> Thanks for looking at the maple tree.  It seems somehow this cover
> letter is detached from the series found here [1].
When sending the patch, my network disconnected a bit and then
resent it again, maybe, perhaps... becomes like this.

>
> All of these look good except 6 and 8, which I have responded to the
> actual patch.  I've indicated below which is 6/8 and 8/8.
>
>
> 1. https://lore.kernel.org/linux-mm/20221220142606.1698836-2-vernon2gm@gmail.com/
>
> Please add my reviewed-by to all patches besides 6 & 8.
> Reviewed-by: Liam R. Howlett <Liam.Howlett@...cle.com>
Okay，thank you reviewed this patchset.

>
> >
> > Vernon Yang (8):
> >   maple_tree: remove extra space and blank line
> >   maple_tree: remove extra return statement
> >   maple_tree: use mt_node_max() instead of direct operations mt_max[]
> >   maple_tree: use macro MA_ROOT_PARENT instead of number
> >   maple_tree: remove the redundant code
>     ^--- 6
>
> >   maple_tree: change return type of mas_commit_b_node()
> >   maple_tree: refine ma_state init from mas_start()
> >   maple_tree: refine mab_calc_split function
>     ^--- 8
> >
> >  include/linux/maple_tree.h |  6 ------
> >  lib/maple_tree.c           | 41 ++++++++++++++------------------------
> >  2 files changed, 15 insertions(+), 32 deletions(-)
> >
> > --
> > 2.34.1
> >