[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e54d0094-5cbd-8710-4fce-5f2d8414bbb7@quicinc.com>
Date: Wed, 21 Dec 2022 11:16:06 +0530
From: Mukesh Ojha <quic_mojha@...cinc.com>
To: Srinivasa Rao Mandadapu <quic_srivasam@...cinc.com>,
<linux-remoteproc@...r.kernel.org>, <agross@...nel.org>,
<andersson@...nel.org>, <lgirdwood@...il.com>,
<broonie@...nel.org>, <robh+dt@...nel.org>,
<quic_plai@...cinc.com>, <bgoswami@...cinc.com>, <perex@...ex.cz>,
<tiwai@...e.com>, <srinivas.kandagatla@...aro.org>,
<quic_rohkumar@...cinc.com>, <linux-arm-msm@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <swboyd@...omium.org>,
<judyhsiao@...omium.org>, <devicetree@...r.kernel.org>,
<krzysztof.kozlowski@...aro.org>, <mathieu.poirier@...aro.org>,
<corbet@....net>
Subject: Re: [PATCH v3 1/2] remoteproc: elf_loader: Update resource table name
check
Hi,
On 12/20/2022 6:20 PM, Mukesh Ojha wrote:
> Hi,
>
> On 12/20/2022 1:31 PM, Srinivasa Rao Mandadapu wrote:
>> Update the way of checking resource table name with prefix
>> substring search instead of complete string search.
>> In general Qualcomm DSP binary is prepared by combining different ELFs',
>> hence section header name (e.g. .resource_table), appended with ELF name
>> to differentiate with same section(e.g. resource_table.ac_bin_process) of
>> different ELFs'.
>> Example readelf output of DSP binary:
>> [60] .start.ac_bin_process PROGBITS
>> [61] .resource_table.ac_bin_process PROGBITS
>> [62] .comment.ac_bin_process PROGBITS
>>
>
> Could we rephrase above like below ? It could be also taken why applying
> the patch.
>
> Update the way of checking resource table name with prefix substring
> search instead of complete string search.
>
> In general, Qualcomm DSP binary is prepared by combining different
> ELF's. Hence, section header name (e.g. .resource_table), appended
> with ELF name to differentiate with same section(e.g.
> resource_table.ac_bin_process) of different ELFs'.
>
> Example readelf output of DSP binary:
> [60] .start.ac_bin_process PROGBITS
> [61] .resource_table.ac_bin_process PROGBITS
> [62] .comment.ac_bin_process PROGBITS
>
>
Looks like my email client did not honour new line
put by me in rephrased text. Sorry for that.
Please run checkpatch.pl before sending the patch.
-Mukesh
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@...cinc.com>
>
> Otherwise, LGTM.
> Reviewed-by: Mukesh Ojha <quic_mojha@...cinc.com>
>
> -Mukesh
>> ---
>> drivers/remoteproc/remoteproc_elf_loader.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/remoteproc/remoteproc_elf_loader.c
>> b/drivers/remoteproc/remoteproc_elf_loader.c
>> index 5a412d7..77330d6 100644
>> --- a/drivers/remoteproc/remoteproc_elf_loader.c
>> +++ b/drivers/remoteproc/remoteproc_elf_loader.c
>> @@ -272,7 +272,7 @@ find_table(struct device *dev, const struct
>> firmware *fw)
>> u64 offset = elf_shdr_get_sh_offset(class, shdr);
>> u32 name = elf_shdr_get_sh_name(class, shdr);
>> - if (strcmp(name_table + name, ".resource_table"))
>> + if (!strstarts(name_table + name, ".resource_table"))
>> continue;
>> table = (struct resource_table *)(elf_data + offset);
Powered by blists - more mailing lists