| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 21 Dec 2022 13:53:17 +0800
From: kernel test robot <lkp@...el.com>
To: Siddh Raman Pant <code@...dh.me>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>
Cc: oe-kbuild-all@...ts.linux.dev,
dri-devel <dri-devel@...ts.freedesktop.org>,
linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 05/10] drm: Remove usage of deprecated DRM_DEBUG
Hi Siddh,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on next-20221220]
[also build test WARNING on linus/master]
[cannot apply to drm-misc/drm-misc-next v6.1 v6.1-rc8 v6.1-rc7 v6.1]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Siddh-Raman-Pant/drm-Remove-usage-of-deprecated-DRM_-macros/20221221-113133
patch link: https://lore.kernel.org/r/0fdcf7a0c9ad77e2d2252cf49fcd5d09952d1b69.1671566741.git.code%40siddh.me
patch subject: [PATCH 05/10] drm: Remove usage of deprecated DRM_DEBUG
config: ia64-allyesconfig
compiler: ia64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/3990929cf97542bbc76cebc444540d0038b9165c
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Siddh-Raman-Pant/drm-Remove-usage-of-deprecated-DRM_-macros/20221221-113133
git checkout 3990929cf97542bbc76cebc444540d0038b9165c
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/gpu/drm/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
In file included from drivers/gpu/drm/drm_pci.c:34:
include/drm/drm_print.h: In function 'drm_legacy_pci_exit':
>> include/drm/drm_print.h:491:34: warning: 'dev' is used uninitialized [-Wuninitialized]
491 | const struct drm_device *drm_ = (drm); \
| ^~~~
drivers/gpu/drm/drm_pci.c:248:28: note: 'dev' was declared here
248 | struct drm_device *dev, *tmp;
| ^~~
vim +/dev +491 include/drm/drm_print.h
e820f52577b14c Jim Cromie 2022-09-11 416
02c9656b2f0d69 Haneen Mohammed 2017-10-17 417 /**
b52817e9de06a3 Mauro Carvalho Chehab 2020-10-27 418 * DRM_DEV_DEBUG() - Debug output for generic drm code
02c9656b2f0d69 Haneen Mohammed 2017-10-17 419 *
306589856399e1 Douglas Anderson 2021-09-21 420 * NOTE: this is deprecated in favor of drm_dbg_core().
306589856399e1 Douglas Anderson 2021-09-21 421 *
091756bbb1a961 Haneen Mohammed 2017-10-17 422 * @dev: device pointer
091756bbb1a961 Haneen Mohammed 2017-10-17 423 * @fmt: printf() like format string.
02c9656b2f0d69 Haneen Mohammed 2017-10-17 424 */
db87086492581c Joe Perches 2018-03-16 425 #define DRM_DEV_DEBUG(dev, fmt, ...) \
db87086492581c Joe Perches 2018-03-16 426 drm_dev_dbg(dev, DRM_UT_CORE, fmt, ##__VA_ARGS__)
b52817e9de06a3 Mauro Carvalho Chehab 2020-10-27 427 /**
b52817e9de06a3 Mauro Carvalho Chehab 2020-10-27 428 * DRM_DEV_DEBUG_DRIVER() - Debug output for vendor specific part of the driver
b52817e9de06a3 Mauro Carvalho Chehab 2020-10-27 429 *
306589856399e1 Douglas Anderson 2021-09-21 430 * NOTE: this is deprecated in favor of drm_dbg() or dev_dbg().
306589856399e1 Douglas Anderson 2021-09-21 431 *
b52817e9de06a3 Mauro Carvalho Chehab 2020-10-27 432 * @dev: device pointer
b52817e9de06a3 Mauro Carvalho Chehab 2020-10-27 433 * @fmt: printf() like format string.
b52817e9de06a3 Mauro Carvalho Chehab 2020-10-27 434 */
db87086492581c Joe Perches 2018-03-16 435 #define DRM_DEV_DEBUG_DRIVER(dev, fmt, ...) \
db87086492581c Joe Perches 2018-03-16 436 drm_dev_dbg(dev, DRM_UT_DRIVER, fmt, ##__VA_ARGS__)
b52817e9de06a3 Mauro Carvalho Chehab 2020-10-27 437 /**
b52817e9de06a3 Mauro Carvalho Chehab 2020-10-27 438 * DRM_DEV_DEBUG_KMS() - Debug output for modesetting code
b52817e9de06a3 Mauro Carvalho Chehab 2020-10-27 439 *
306589856399e1 Douglas Anderson 2021-09-21 440 * NOTE: this is deprecated in favor of drm_dbg_kms().
306589856399e1 Douglas Anderson 2021-09-21 441 *
b52817e9de06a3 Mauro Carvalho Chehab 2020-10-27 442 * @dev: device pointer
b52817e9de06a3 Mauro Carvalho Chehab 2020-10-27 443 * @fmt: printf() like format string.
b52817e9de06a3 Mauro Carvalho Chehab 2020-10-27 444 */
db87086492581c Joe Perches 2018-03-16 445 #define DRM_DEV_DEBUG_KMS(dev, fmt, ...) \
db87086492581c Joe Perches 2018-03-16 446 drm_dev_dbg(dev, DRM_UT_KMS, fmt, ##__VA_ARGS__)
a18b21929453af Lyude Paul 2018-07-16 447
fb6c7ab8718eb2 Jani Nikula 2019-12-10 448 /*
fb6c7ab8718eb2 Jani Nikula 2019-12-10 449 * struct drm_device based logging
fb6c7ab8718eb2 Jani Nikula 2019-12-10 450 *
fb6c7ab8718eb2 Jani Nikula 2019-12-10 451 * Prefer drm_device based logging over device or prink based logging.
fb6c7ab8718eb2 Jani Nikula 2019-12-10 452 */
fb6c7ab8718eb2 Jani Nikula 2019-12-10 453
fb6c7ab8718eb2 Jani Nikula 2019-12-10 454 /* Helper for struct drm_device based logging. */
fb6c7ab8718eb2 Jani Nikula 2019-12-10 455 #define __drm_printk(drm, level, type, fmt, ...) \
fb6c7ab8718eb2 Jani Nikula 2019-12-10 456 dev_##level##type((drm)->dev, "[drm] " fmt, ##__VA_ARGS__)
fb6c7ab8718eb2 Jani Nikula 2019-12-10 457
fb6c7ab8718eb2 Jani Nikula 2019-12-10 458
fb6c7ab8718eb2 Jani Nikula 2019-12-10 459 #define drm_info(drm, fmt, ...) \
fb6c7ab8718eb2 Jani Nikula 2019-12-10 460 __drm_printk((drm), info,, fmt, ##__VA_ARGS__)
fb6c7ab8718eb2 Jani Nikula 2019-12-10 461
fb6c7ab8718eb2 Jani Nikula 2019-12-10 462 #define drm_notice(drm, fmt, ...) \
fb6c7ab8718eb2 Jani Nikula 2019-12-10 463 __drm_printk((drm), notice,, fmt, ##__VA_ARGS__)
fb6c7ab8718eb2 Jani Nikula 2019-12-10 464
fb6c7ab8718eb2 Jani Nikula 2019-12-10 465 #define drm_warn(drm, fmt, ...) \
fb6c7ab8718eb2 Jani Nikula 2019-12-10 466 __drm_printk((drm), warn,, fmt, ##__VA_ARGS__)
fb6c7ab8718eb2 Jani Nikula 2019-12-10 467
fb6c7ab8718eb2 Jani Nikula 2019-12-10 468 #define drm_err(drm, fmt, ...) \
fb6c7ab8718eb2 Jani Nikula 2019-12-10 469 __drm_printk((drm), err,, "*ERROR* " fmt, ##__VA_ARGS__)
fb6c7ab8718eb2 Jani Nikula 2019-12-10 470
fb6c7ab8718eb2 Jani Nikula 2019-12-10 471
fb6c7ab8718eb2 Jani Nikula 2019-12-10 472 #define drm_info_once(drm, fmt, ...) \
fb6c7ab8718eb2 Jani Nikula 2019-12-10 473 __drm_printk((drm), info, _once, fmt, ##__VA_ARGS__)
fb6c7ab8718eb2 Jani Nikula 2019-12-10 474
fb6c7ab8718eb2 Jani Nikula 2019-12-10 475 #define drm_notice_once(drm, fmt, ...) \
fb6c7ab8718eb2 Jani Nikula 2019-12-10 476 __drm_printk((drm), notice, _once, fmt, ##__VA_ARGS__)
fb6c7ab8718eb2 Jani Nikula 2019-12-10 477
fb6c7ab8718eb2 Jani Nikula 2019-12-10 478 #define drm_warn_once(drm, fmt, ...) \
fb6c7ab8718eb2 Jani Nikula 2019-12-10 479 __drm_printk((drm), warn, _once, fmt, ##__VA_ARGS__)
fb6c7ab8718eb2 Jani Nikula 2019-12-10 480
fb6c7ab8718eb2 Jani Nikula 2019-12-10 481 #define drm_err_once(drm, fmt, ...) \
fb6c7ab8718eb2 Jani Nikula 2019-12-10 482 __drm_printk((drm), err, _once, "*ERROR* " fmt, ##__VA_ARGS__)
fb6c7ab8718eb2 Jani Nikula 2019-12-10 483
fb6c7ab8718eb2 Jani Nikula 2019-12-10 484
fb6c7ab8718eb2 Jani Nikula 2019-12-10 485 #define drm_err_ratelimited(drm, fmt, ...) \
fb6c7ab8718eb2 Jani Nikula 2019-12-10 486 __drm_printk((drm), err, _ratelimited, "*ERROR* " fmt, ##__VA_ARGS__)
fb6c7ab8718eb2 Jani Nikula 2019-12-10 487
fb6c7ab8718eb2 Jani Nikula 2019-12-10 488
fb6c7ab8718eb2 Jani Nikula 2019-12-10 489 #define drm_dbg_core(drm, fmt, ...) \
24eb20345874ac Siddh Raman Pant 2022-12-21 490 ({ \
24eb20345874ac Siddh Raman Pant 2022-12-21 @491 const struct drm_device *drm_ = (drm); \
24eb20345874ac Siddh Raman Pant 2022-12-21 492 drm_dev_dbg(drm_ ? drm_->dev : NULL, DRM_UT_CORE, \
24eb20345874ac Siddh Raman Pant 2022-12-21 493 fmt, ##__VA_ARGS__); \
24eb20345874ac Siddh Raman Pant 2022-12-21 494 })
24eb20345874ac Siddh Raman Pant 2022-12-21 495
--
0-DAY CI Kernel Test Service
https://01.org/lkp
View attachment "config" of type "text/plain" (324583 bytes)
Powered by blists - more mailing lists