linux-kernel - Re: [PATCH v2] arm64: dts: rockchip: Add RK3566 LubanCat 1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMmci2UNqbv-ViaGM5Avi5fhSEuDa=MFkq1bDXyDsrNFM=t0jA@mail.gmail.com>
Date:   Wed, 21 Dec 2022 14:05:25 +0800
From:   ty <zonyitoo@...il.com>
To:     Heiko Stübner <heiko@...ech.de>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Peter Geis <pgwipeout@...il.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, DHDAXCW <lasstp5011@...il.com>
Subject: Re: [PATCH v2] arm64: dts: rockchip: Add RK3566 LubanCat 1

ok. Modifications are made in PATCH v4.

NOTE: PATCH v3 was sent with an old patch file as attachment, so please ignore.
NOTE: Last Reply E-mail were sent in HTML mode.


Heiko Stübner <heiko@...ech.de> 于2022年12月21日周三 01:32写道：
>
> Am Dienstag, 20. Dezember 2022, 17:14:51 CET schrieb Krzysztof Kozlowski:
> > On 20/12/2022 11:21, Yuteng Zhong wrote:
> > > LubanCat 1 is a Rockchip RK3566 SBC based
> > > is developed by EmbedFire Electronics Co., Ltd.
> > > Mini Linux Card Type Cheap Computer Development Board
> >
> > Please wrap commit message according to Linux coding style / submission
> > process:
> > https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586
> >
> > > +   rk809: pmic@20 {
> > > +           compatible = "rockchip,rk809";
> > > +           reg = <0x20>;
> > > +           interrupt-parent = <&gpio0>;
> > > +           interrupts = <RK_PA3 IRQ_TYPE_LEVEL_LOW>;
> > > +           assigned-clocks = <&cru I2S1_MCLKOUT_TX>;
> > > +           assigned-clock-parents = <&cru CLK_I2S1_8CH_TX>;
> > > +           #clock-cells = <1>;
> > > +           clock-names = "mclk";
> > > +           clocks = <&cru I2S1_MCLKOUT_TX>;
> > > +           pinctrl-names = "default";
> > > +           pinctrl-0 = <&pmic_int>;
> > > +           rockchip,system-power-controller;
> > > +           #sound-dai-cells = <0>;
> > > +           vcc1-supply = <&vcc3v3_sys>;
> > > +           vcc2-supply = <&vcc3v3_sys>;
> > > +           vcc3-supply = <&vcc3v3_sys>;
> > > +           vcc4-supply = <&vcc3v3_sys>;
> > > +           vcc5-supply = <&vcc3v3_sys>;
> > > +           vcc6-supply = <&vcc3v3_sys>;
> > > +           vcc7-supply = <&vcc3v3_sys>;
> > > +           vcc8-supply = <&vcc3v3_sys>;
> > > +           vcc9-supply = <&vcc3v3_sys>;
> > > +           wakeup-source;
> > > +
> > > +           regulators {
> > > +                   vdd_logic: DCDC_REG1 {
> >
> > No underscores in node names. Anything requires it?
>
> looks like the answer is "it depends" :-)
>
> When the regulator-framework searches for the node to get the init-data from
> it uses the actual node-name or the regulator-compatible property [0]
> to match against.
>
> And going via regulator-compatible was the "old" way, already deprecated
> before the yaml-conversion [1] and not even included
>
> So matching against the node-name is the correct way to go and it's actually
> part of the rk8xx-binding as well [2]
>
>
> Hope that helps,
> Heiko
>
>
> [0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/regulator/of_regulator.c#n477
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/Documentation/devicetree/bindings/regulator/regulator.txt?id=1914a996436b09186489da73b807e1df71259f67
> [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml#n84
>
>


-- 
Y. T. Zhong
Student of The University of Hong Kong, major in Computer Science.
E-mail: zonyitoo@...il.com