linux-kernel - Re: [PATCH] vdpa_sim: use weak barriers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221221091732.gvc724dnq2ntza7g@sgarzare-redhat>
Date:   Wed, 21 Dec 2022 10:17:32 +0100
From:   Stefano Garzarella <sgarzare@...hat.com>
To:     Jason Wang <jasowang@...hat.com>
Cc:     mst@...hat.com, eperezma@...hat.com,
        virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vdpa_sim: use weak barriers

On Wed, Dec 21, 2022 at 02:21:46PM +0800, Jason Wang wrote:
>vDPA simulators are software emulated device, so let's switch to use
>weak barriers to avoid extra overhead in the driver.
>
>Signed-off-by: Jason Wang <jasowang@...hat.com>
>---
> drivers/vdpa/vdpa_sim/vdpa_sim.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

I was going to propose the same :-)

Reviewed-by: Stefano Garzarella <sgarzare@...hat.com>

>
>diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c
>index b071f0d842fb..eeaeaf43b476 100644
>--- a/drivers/vdpa/vdpa_sim/vdpa_sim.c
>+++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c
>@@ -68,7 +68,7 @@ static void vdpasim_queue_ready(struct vdpasim *vdpasim, unsigned int idx)
> 	struct vdpasim_virtqueue *vq = &vdpasim->vqs[idx];
>
> 	vringh_init_iotlb(&vq->vring, vdpasim->dev_attr.supported_features,
>-			  VDPASIM_QUEUE_MAX, false,
>+			  VDPASIM_QUEUE_MAX, true,
> 			  (struct vring_desc *)(uintptr_t)vq->desc_addr,
> 			  (struct vring_avail *)
> 			  (uintptr_t)vq->driver_addr,
>-- 
>2.25.1
>