linux-kernel - Re: [PATCH] rust: prelude: prevent doc inline of external imports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <CP7E4XY0O87Z.1JFRPGL7BMGZ3@vincent>
Date:   Wed, 21 Dec 2022 10:33:29 +0100
From:   "Vincenzo" <vincenzopalazzodev@...il.com>
To:     "Finn Behrens" <fin@...ntec.com>,
        "Miguel Ojeda" <ojeda@...nel.org>,
        "Wedson Almeida Filho" <wedsonaf@...il.com>,
        "Alex Gaynor" <alex.gaynor@...il.com>,
        "Boqun Feng" <boqun.feng@...il.com>, "Gary Guo" <gary@...yguo.net>,
        Björn Roy Baron <bjorn3_gh@...tonmail.com>
Cc:     <rust-for-linux@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <patches@...ts.linux.dev>
Subject: Re: [PATCH] rust: prelude: prevent doc inline of external imports

IMOHO this make sense.

Reviewed-by: Vincenzo Palazzo <vincenzopalazzodev@...il.com> 

On Wed Dec 14, 2022 at 10:34 AM CET, Finn Behrens wrote:
> This shows exactly where the items are from, previously the items from
> macros, alloc and core where shown as a decleration from the kernel crate,
> this shows the correct path.
>
> Signed-off-by: Finn Behrens <fin@...ntec.com>
> ---
>  rust/kernel/prelude.rs | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/rust/kernel/prelude.rs b/rust/kernel/prelude.rs
> index 7a90249ee9b9..917721e791b6 100644
> --- a/rust/kernel/prelude.rs
> +++ b/rust/kernel/prelude.rs
> @@ -11,15 +11,21 @@
>  //! use kernel::prelude::*;
>  //! ```
>  
> +#[doc(no_inline)]
>  pub use core::pin::Pin;
>  
> +#[doc(no_inline)]
>  pub use alloc::{boxed::Box, vec::Vec};
>  
> +#[doc(no_inline)]
>  pub use macros::{module, vtable};
>  
>  pub use super::build_assert;
>  
> -pub use super::{dbg, pr_alert, pr_crit, pr_debug, pr_emerg, pr_err, pr_info, pr_notice, pr_warn};
> +// super::std_vendor is hidden, which makes the macro inline for some reason
> +#[doc(no_inline)]
> +pub use super::dbg;
> +pub use super::{pr_alert, pr_crit, pr_debug, pr_emerg, pr_err, pr_info, pr_notice, pr_warn};
>  
>  pub use super::static_assert;
>  
> -- 
> 2.31.1