linux-kernel - Re: [PATCH v4 2/2] dt-bindings: arm: rockchip: Add EmbedFire LubanCat 1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 21 Dec 2022 12:41:10 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     ty <zonyitoo@...il.com>
Cc:     Heiko Stuebner <heiko@...ech.de>, Rob Herring <robh+dt@...nel.org>,
        Peter Geis <pgwipeout@...il.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, DHDAXCW <lasstp5011@...il.com>
Subject: Re: [PATCH v4 2/2] dt-bindings: arm: rockchip: Add EmbedFire LubanCat
 1

On 21/12/2022 11:46, ty wrote:
> Dear Kozlowski,
> 
> Sorry that we didn't fully get the idea in your previous comments.
> 
>>
>> On 21/12/2022 06:52, Yuteng Zhong wrote:
>>> from: DHDAXCW <lasstp5011@...il.com>
>>>
>>> LubanCat 1 is a Rockchip RK3566 SBC based
>>> is developed by EmbedFire Electronics Co., Ltd.
>>> Mini Linux Card Type Cheap Computer Development Board
>>
>> This is a friendly reminder during the review process.
>>
>> It seems my previous comments were not fully addressed. Maybe my
>> feedback got lost between the quotes, maybe you just forgot to apply it.
>> Please go back to the previous discussion and either implement all
>> requested changes or keep discussing them.
>>
>> Thank you.
> 
> Your pervious comment were:
> 
>> Please wrap commit message according to Linux coding style / submission
>> process:
>> https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586
> 
> So I think there must be something wrong in the message but I didn't
> notice. This message has a `from` line, and the body was wrapped at 75
> columns. Please help me make it better.

You do not wrap at 75, but at some other place. Just put it to editor
and check where is wrapping (count characters).

> 
> 
> 
>>>
>>> Signed-off-by: Yuteng Zhong <zonyitoo@...il.com>
>>> Signed-off-by: DHDAXCW <lasstp5011@...il.com>
>>> ---
>>>  Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
>>>  1 file changed, 5 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
>>> index 88ff4422a8c1..84d39a3a8843 100644
>>> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
>>> @@ -781,6 +781,11 @@ properties:
>>>            - const: rockchip,rk3568-bpi-r2pro
>>>            - const: rockchip,rk3568
>>>
>>> +      - description: EmbedFire LubanCat 1
>>> +        items:
>>> +          - const: embedfire,lubancat-1
>>> +          - const: rockchip,rk3566
>>
>> Here as well.
> 
> This change was addressing the previous comment in V2:
> 
>> This is separate patch. Does not look like properly ordered. Don't add
>> stuff at the end of files/lists.
> 
> The previous PATCH v2 merged changes in 3 diffent files:
> 
> 1. arch/arm64/boot/dts/rockchip/Makefile
> 2. arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
> 3. Documentation/devicetree/bindings/arm/rockchip.yaml
> 
> What we do in this PATCH v4 was separated the 3 into a separated patch.

So how did you solve the comment "Does not look like properly ordered.
Don't add stuff at the end of files/lists."? What did you change to
solve it?

Best regards,
Krzysztof