linux-kernel - RE: [PATCH v3 1/2] dt-bindings: pinctrl: add schema for NXP S32 SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 21 Dec 2022 12:28:58 +0000
From:   Andrei Stefanescu <andrei.stefanescu@....com>
To:     Chester Lin <clin@...e.com>, Rob Herring <robh+dt@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Andreas Färber <afaerber@...e.de>
CC:     dl-S32 <S32@....com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Larisa Ileana Grigore <larisa.grigore@....com>,
        "Ghennadi Procopciuc (OSS)" <ghennadi.procopciuc@....nxp.com>,
        Matthias Brugger <mbrugger@...e.com>
Subject: RE: [PATCH v3 1/2] dt-bindings: pinctrl: add schema for NXP S32 SoCs

Hi Chester,

> +patternProperties:
> +  '-pins$':

Sorry, I missed this in the previous versions. Could you change it to '_pins' (underscore)? In our .dts files we use underscore in the names for pinctrl configuration nodes e.g. i2c4_pins, usbotg_pins.

> +    patternProperties:
> +      '-grp[0-9]$':

The same comment also applies here.

> +        llce-can0-pins {
> +            llce-can0-grp0 {

This should also change to something like:
llce_can0_pins {
  llce_can0_grp0 {
    ...
  }
}

Otherwise, this and PATCH 2/2 look good to me.

Best regards,
Andrei