linux-kernel - Re: [PATCH v3 1/2] dt-bindings: pinctrl: add schema for NXP S32 SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y6MPnJ27IKFiNltl@linux-8mug>
Date:   Wed, 21 Dec 2022 21:52:28 +0800
From:   Chester Lin <clin@...e.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Andrei Stefanescu <andrei.stefanescu@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Andreas Färber <afaerber@...e.de>,
        dl-S32 <S32@....com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Larisa Ileana Grigore <larisa.grigore@....com>,
        "Ghennadi Procopciuc (OSS)" <ghennadi.procopciuc@....nxp.com>,
        Matthias Brugger <mbrugger@...e.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: pinctrl: add schema for NXP S32 SoCs

Hi Krzysztof and Andrei,

Thanks for reviewing this patch!

On Wed, Dec 21, 2022 at 01:30:12PM +0100, Krzysztof Kozlowski wrote:
> On 21/12/2022 13:28, Andrei Stefanescu wrote:
> > Hi Chester,
> > 
> >> +patternProperties:
> >> +  '-pins$':
> > 
> > Sorry, I missed this in the previous versions. Could you change it to '_pins' (underscore)? In our .dts files we use underscore in the names for pinctrl configuration nodes e.g. i2c4_pins, usbotg_pins.
> 
> You cannot have underscores as node names, so what do you mean here? You

Krzysztof is right, and Rob also reminded me in his comments in v1:

https://lore.kernel.org/linux-arm-kernel/20221102154903.GA3726664-robh@kernel.org/

Regards,
Chester

> need to fix your DTS not introduce bad practices to mainline kernel.
> 
> Best regards,
> Krzysztof
>