linux-kernel - Re: [PATCH V2 1/4] ASoC: amd: ps: implement api to retrieve acp device config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Dec 2022 00:40:05 +0800
From:   kernel test robot <lkp@...el.com>
To:     Vijendar Mukunda <Vijendar.Mukunda@....com>, broonie@...nel.org,
        alsa-devel@...a-project.org
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        Basavaraj.Hiregoudar@....com, Sunil-kumar.Dommati@....com,
        Mario.Limonciello@....com,
        Vijendar Mukunda <Vijendar.Mukunda@....com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Syed Saba Kareem <Syed.SabaKareem@....com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2 1/4] ASoC: amd: ps: implement api to retrieve acp
 device config

Hi Vijendar,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on broonie-sound/for-next]
[also build test WARNING on linus/master next-20221220]
[cannot apply to v6.1]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Vijendar-Mukunda/ASoC-amd-ps-implement-api-to-retrieve-acp-device-config/20221221-192703
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
patch link:    https://lore.kernel.org/r/20221221112611.1373278-1-Vijendar.Mukunda%40amd.com
patch subject: [PATCH V2 1/4] ASoC: amd: ps: implement api to retrieve acp device config
config: x86_64-randconfig-a015-20221219
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/a47d6a455ff7716688a8c7efaae89f07cebf118d
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Vijendar-Mukunda/ASoC-amd-ps-implement-api-to-retrieve-acp-device-config/20221221-192703
        git checkout a47d6a455ff7716688a8c7efaae89f07cebf118d
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash sound/soc/amd/ps/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> sound/soc/amd/ps/pci-ps.c:135:6: warning: no previous prototype for function 'get_acp63_device_config' [-Wmissing-prototypes]
   void get_acp63_device_config(u32 config, struct pci_dev *pci, struct acp63_dev_data *acp_data)
        ^
   sound/soc/amd/ps/pci-ps.c:135:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void get_acp63_device_config(u32 config, struct pci_dev *pci, struct acp63_dev_data *acp_data)
   ^
   static 
   sound/soc/amd/ps/pci-ps.c:231:60: error: use of undeclared identifier 'ACP_DMIC_ADDR'
                   adev = acpi_find_child_device(ACPI_COMPANION(&pci->dev), ACP_DMIC_ADDR, 0);
                                                                            ^
   1 warning and 1 error generated.


vim +/get_acp63_device_config +135 sound/soc/amd/ps/pci-ps.c

   134	
 > 135	void get_acp63_device_config(u32 config, struct pci_dev *pci, struct acp63_dev_data *acp_data)
   136	{
   137		struct acpi_device *dmic_dev;
   138		const union acpi_object *obj;
   139		bool is_dmic_dev = false;
   140	
   141		dmic_dev = acpi_find_child_device(ACPI_COMPANION(&pci->dev), ACP63_DMIC_ADDR, 0);
   142		if (dmic_dev) {
   143			if (!acpi_dev_get_property(dmic_dev, "acp-audio-device-type",
   144						   ACPI_TYPE_INTEGER, &obj) &&
   145						   obj->integer.value == ACP_DMIC_DEV)
   146				is_dmic_dev = true;
   147		}
   148	
   149		switch (config) {
   150		case ACP_CONFIG_0:
   151		case ACP_CONFIG_1:
   152		case ACP_CONFIG_2:
   153		case ACP_CONFIG_3:
   154		case ACP_CONFIG_9:
   155		case ACP_CONFIG_15:
   156			dev_dbg(&pci->dev, "Audio Mode %d\n", config);
   157			break;
   158		default:
   159			if (is_dmic_dev) {
   160				acp_data->pdev_mask = ACP63_PDM_DEV_MASK;
   161				acp_data->pdev_count = ACP63_PDM_MODE_DEVS;
   162			}
   163			break;
   164		}
   165	}
   166	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (144624 bytes)