linux-kernel - Re: [PATCH v2 1/2] Documentation: dt-bindings: k3-r5f-rproc: Add new compatible for AM62 SoC family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <621910a0-d851-409b-99e8-7bdf95dc539d@linaro.org>
Date:   Wed, 21 Dec 2022 18:17:30 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Devarsh Thakkar <devarsht@...com>, andersson@...nel.org,
        mathieu.poirier@...aro.org, p.zabel@...gutronix.de,
        linux-remoteproc@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, s-anna@...com
Cc:     robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        hnagalla@...com, praneeth@...com, nm@...com, vigneshr@...com,
        a-bhatia1@...com, j-luthra@...com
Subject: Re: [PATCH v2 1/2] Documentation: dt-bindings: k3-r5f-rproc: Add new
 compatible for AM62 SoC family

On 21/12/2022 17:29, Devarsh Thakkar wrote:
>>
>> Just look at your patch - it is clearly incorrect. You said in the patch
>> that for compatibles other than ti,am64-r5fss cluster mode is BOTH [0,
>> 1] AND false.
> 
> cluster-mode is BOTH [0,1] and false only in case of AM62x as per below snippet

Yes, for that variant you have conflicting approach.

, but since it's under allOf the impact of latter will supersede, schema
validation will fail even if cluster-mode set to 0 or 1 for am62x due to
below snippet as shared in obesrvation log above [2].

Yeah, but the code is confusing. So again - you are saying with allOf
that both conditions are applicable. Your intentions of superseding do
not matter here - you said that allOf conditions must be taken into
account. These conditions can be reversed any time, don't you think?


> 
> "  - if:
>       properties:
>         compatible:
>           enum:
>             - ti,am62-r5fss
>     then:
>       properties:
>         ti,cluster-mode: false"
> 
> Sorry for the back and forth, I just thought to describe more clearly what I was up-to as I thought above should be functionally fine and it also saves us from having separate if blocks for each compatible, but I am open to adding separate if blocks as you earlier suggested if that seems more cleaner solution.

You need to fix your email client to properly wrap messages.

Best regards,
Krzysztof