linux-kernel - Re: [PATCH 1/2] scsi: ufs: core: Add hibernation callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Dec 2022 03:01:40 +0800
From:   kernel test robot <lkp@...el.com>
To:     Anjana Hari <quic_ahari@...cinc.com>, agross@...nel.org,
        andersson@...nel.org, jejb@...ux.ibm.com,
        martin.petersen@...cle.com
Cc:     oe-kbuild-all@...ts.linux.dev, alim.akhtar@...sung.com,
        avri.altman@....com, bvanassche@....org, konrad.dybcio@...aro.org,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        quic_narepall@...cinc.com, quic_nitirawa@...cinc.com,
        quic_rampraka@...cinc.com, Anjana Hari <quic_ahari@...cinc.com>
Subject: Re: [PATCH 1/2] scsi: ufs: core: Add hibernation callbacks

Hi Anjana,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on mkp-scsi/for-next]
[also build test ERROR on jejb-scsi/for-next linus/master v6.1 next-20221220]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Anjana-Hari/scsi-ufs-Add-hibernation-callbacks/20221222-011920
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
patch link:    https://lore.kernel.org/r/20221221171222.19699-2-quic_ahari%40quicinc.com
patch subject: [PATCH 1/2] scsi: ufs: core: Add hibernation callbacks
config: m68k-allmodconfig
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/f323382d9a7789fabe32275640cf8bebbc569c5d
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Anjana-Hari/scsi-ufs-Add-hibernation-callbacks/20221222-011920
        git checkout f323382d9a7789fabe32275640cf8bebbc569c5d
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/ufs/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/ufs/core/ufshcd.c: In function 'ufshcd_system_freeze':
>> drivers/ufs/core/ufshcd.c:9650:15: error: implicit declaration of function 'ufshcd_system_suspend'; did you mean 'trace_ufshcd_system_suspend'? [-Werror=implicit-function-declaration]
    9650 |         ret = ufshcd_system_suspend(dev);
         |               ^~~~~~~~~~~~~~~~~~~~~
         |               trace_ufshcd_system_suspend
   drivers/ufs/core/ufshcd.c: In function 'ufshcd_system_restore':
>> drivers/ufs/core/ufshcd.c:9671:15: error: implicit declaration of function 'ufshcd_system_resume'; did you mean 'ufshcd_system_restore'? [-Werror=implicit-function-declaration]
    9671 |         ret = ufshcd_system_resume(dev);
         |               ^~~~~~~~~~~~~~~~~~~~
         |               ufshcd_system_restore
   cc1: some warnings being treated as errors


vim +9650 drivers/ufs/core/ufshcd.c

  9639	
  9640		struct ufs_hba *hba = dev_get_drvdata(dev);
  9641		int ret = 0;
  9642	
  9643		/*
  9644		 * Run time resume the controller to make sure
  9645		 * the PM work queue threads do not try to resume
  9646		 * the child (scsi host), which leads to errors as
  9647		 * the controller is not yet resumed.
  9648		 */
  9649		pm_runtime_get_sync(hba->dev);
> 9650		ret = ufshcd_system_suspend(dev);
  9651		pm_runtime_put_sync(hba->dev);
  9652	
  9653		/*
  9654		 * Ensure no runtime PM operations take
  9655		 * place in the hibernation and restore sequence
  9656		 * on successful freeze operation.
  9657		 */
  9658		if (!ret)
  9659			pm_runtime_disable(hba->dev);
  9660	
  9661		return 0;
  9662	}
  9663	EXPORT_SYMBOL_GPL(ufshcd_system_freeze);
  9664	
  9665	int ufshcd_system_restore(struct device *dev)
  9666	{
  9667		struct ufs_hba *hba = dev_get_drvdata(dev);
  9668		int ret = 0;
  9669	
  9670		hba->restore = true;
> 9671		ret = ufshcd_system_resume(dev);
  9672	
  9673		/*
  9674		 * Now any runtime PM operations can be
  9675		 * allowed on successful restore operation
  9676		 */
  9677		if (!ret)
  9678			pm_runtime_enable(hba->dev);
  9679	
  9680		return ret;
  9681	}
  9682	EXPORT_SYMBOL_GPL(ufshcd_system_restore);
  9683	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (276518 bytes)