linux-kernel - Re: [PATCH v2] scsi: libsas: Fix did not grab the ata port lock in sas_ata_device_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c75ffece-15d4-37c6-b09c-8032f0a21d77@huawei.com>
Date:   Wed, 21 Dec 2022 10:50:45 +0800
From:   Jason Yan <yanaijie@...wei.com>
To:     Xingui Yang <yangxingui@...wei.com>, <jejb@...ux.ibm.com>,
        <martin.petersen@...cle.com>, <john.g.garry@...cle.com>
CC:     <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linuxarm@...wei.com>, <prime.zeng@...ilicon.com>,
        <kangfenglong@...wei.com>
Subject: Re: [PATCH v2] scsi: libsas: Fix did not grab the ata port lock in
 sas_ata_device_link_abort()

On 2022/12/21 9:52, Xingui Yang wrote:
> Grab the ata port lock in sas_ata_device_link_abort() before calling
> ata_link_abort(), as the comment in ata_link_abort() mentions.
> 
> Fixes: 44112922674b ("scsi: libsas: Add sas_ata_device_link_abort()")
> Signed-off-by: Xingui Yang <yangxingui@...wei.com>
> Reviewed-by: John Garry <john.g.garry@...cle.com>
> ---
> Changes to v1:
> - Add a fixes tag
> - Update commit message
> ---
>   drivers/scsi/libsas/sas_ata.c | 3 +++
>   1 file changed, 3 insertions(+)

Looks good,
Reviewed-by: Jason Yan <yanaijie@...wei.com>