linux-kernel - Re: [PATCH v3 0/7] dts: qcom: sc8280xp: add i2c, spi, and rng nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4d434dd7-cd3c-ed53-c337-4cf1ba018aef@kali.org>
Date:   Wed, 21 Dec 2022 13:41:52 -0600
From:   Steev Klimaszewski <steev@...i.org>
To:     Brian Masney <bmasney@...hat.com>, andersson@...nel.org,
        krzysztof.kozlowski+dt@...aro.org
Cc:     quic_shazhuss@...cinc.com, konrad.dybcio@...aro.org,
        robh+dt@...nel.org, johan+linaro@...nel.org,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, ahalaney@...hat.com,
        echanude@...hat.com
Subject: Re: [PATCH v3 0/7] dts: qcom: sc8280xp: add i2c, spi, and rng nodes


On 12/20/22 1:28 PM, Brian Masney wrote:
> This patch series adds the i2c and spi nodes that are missing on the
> sc8280xp platform. Since I am already making changes to sc8280xp.dtsi
> in this series, I also included a change to enable the rng node for this
> platform as well.
>
> The first three patches in this series are new in v2 and rename one node
> at a time to try to make the review easier. Each patch has a changelog.
>
> Note that this series needs to be applied on top of:
> [PATCH v5] arm64: dts: qcom: sa8540p-ride: enable pcie2a node
> https://lore.kernel.org/lkml/20221213095922.11649-1-quic_shazhuss@quicinc.com/
>
> Changes from v2 to v3:
> - Reordered rng node in patch 7 so that it's sorted correctly by address
> - Since I respun the series, I made Konrad's sort order suggestion to
>    the state nodes since I'm making changes here.
> - Collected R-b and T-b tags.
>
> Brian Masney (7):
>    arm64: dts: qcom: sc8280xp: rename qup2_uart17 to uart17
>    arm64: dts: qcom: sc8280xp: rename qup2_i2c5 to i2c21
>    arm64: dts: qcom: sc8280xp: rename qup0_i2c4 to i2c4
>    arm64: dts: qcom: sc8280xp: add missing i2c nodes
>    arm64: dts: qcom: sc8280xp: add missing spi nodes
>    arm64: dts: qcom: sa8540p-ride: add i2c nodes
>    arm64: dts: qcom: sc8280xp: add rng device tree node
>
>   arch/arm64/boot/dts/qcom/sa8295p-adp.dts      |  12 +-
>   arch/arm64/boot/dts/qcom/sa8540p-ride.dts     |  91 ++-
>   arch/arm64/boot/dts/qcom/sc8280xp-crd.dts     | 160 ++--
>   .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts    | 178 ++---
>   arch/arm64/boot/dts/qcom/sc8280xp.dtsi        | 725 +++++++++++++++++-
>   5 files changed, 983 insertions(+), 183 deletions(-)


One note, and this isn't due to your patches at all, but the touchscreen 
on the Thinkpad X13s needs to be manually bound in order to work via 
echo 1-0010 | sudo tee /sys/bus/i2c/drivers/i2c_hid_of/bind - this patch 
does not affect that, though I had hoped maybe it would.

Tested on the Lenovo Thinkpad X13s

Tested-by: Steev Klimaszewski <steev@...i.org>