linux-kernel - Re: [PATCH v5 04/21] dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <00bcc651-3540-04b1-e0c0-d80335bf1bff@linaro.org>
Date:   Thu, 22 Dec 2022 12:48:18 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        linux-arm-msm@...r.kernel.org, freedreno@...ts.freedesktop.org,
        devicetree@...r.kernel.org
Cc:     robdclark@...il.com, quic_abhinavk@...cinc.com,
        dmitry.baryshkov@...aro.org, sean@...rly.run, airlied@...il.com,
        daniel@...ll.ch, robh+dt@...nel.org, dianders@...omium.org,
        david@...t.cz, krzysztof.kozlowski+dt@...aro.org,
        swboyd@...omium.org, konrad.dybcio@...ainline.org,
        agross@...nel.org, andersson@...nel.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 04/21] dt-bindings: msm: dsi-controller-main: Add
 compatible strings for every current SoC

On 22/12/2022 12:47, Krzysztof Kozlowski wrote:
> On 20/12/2022 13:36, Bryan O'Donoghue wrote:
>> Currently we do not differentiate between the various users of the
>> qcom,mdss-dsi-ctrl. The driver is flexible enough to operate from one
>> compatible string but, the hardware does have some significant differences
>> in the number of clocks.
>>
>> To facilitate documenting the clocks add the following compatible strings
>>
>> - qcom,apq8064-dsi-ctrl
>> - qcom,msm8916-dsi-ctrl
>> - qcom,msm8953-dsi-ctrl
>> - qcom,msm8974-dsi-ctrl
>> - qcom,msm8996-dsi-ctrl
>> - qcom,msm8998-dsi-ctrl
>> - qcom,sc7180-dsi-ctrl
>> - qcom,sc7280-dsi-ctrl
>> - qcom,sdm660-dsi-ctrl
>> - qcom,sdm845-dsi-ctrl
>> - qcom,sm8250-dsi-ctrl
>>
>> Each SoC dtsi should declare "qcom,socname-dsi-ctrl", "qcom,mdss-dsi-ctrl";
>>
>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
>> ---
>>  .../display/msm/dsi-controller-main.yaml      | 20 +++++++++++++++----
>>  1 file changed, 16 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
>> index 6e2fd6e9fa7f0..01afa9e9c4b3c 100644
>> --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
>> +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
>> @@ -14,9 +14,21 @@ allOf:
>>  
>>  properties:
>>    compatible:
>> -    enum:
>> -      - qcom,mdss-dsi-ctrl
>> -      - qcom,dsi-ctrl-6g-qcm2290
>> +    items:
>> +      - enum:
>> +          - qcom,apq8064-dsi-ctrl
>> +          - qcom,msm8916-dsi-ctrl
>> +          - qcom,msm8953-dsi-ctrl
>> +          - qcom,msm8974-dsi-ctrl
>> +          - qcom,msm8996-dsi-ctrl
>> +          - qcom,msm8998-dsi-ctrl
>> +          - qcom,dsi-ctrl-6g-qcm2290
>> +          - qcom,sc7180-dsi-ctrl
>> +          - qcom,sc7280-dsi-ctrl
>> +          - qcom,sdm660-dsi-ctrl
>> +          - qcom,sdm845-dsi-ctrl
>> +          - qcom,sm8250-dsi-ctrl
> 
> Usual comment: can we keep the list sorted?

Actually it is sorted, except the qcom,dsi-ctrl-6g-qcm2290. Please move
it after apq.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof