linux-kernel - Re: [PATCH] blk-iocost: don't make all constants unsigned long long

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221222135855.GC20830@blackbody.suse.cz>
Date:   Thu, 22 Dec 2022 14:58:55 +0100
From:   Michal Koutný <mkoutny@...e.com>
To:     Yann Droneaud <ydroneaud@...eya.com>
Cc:     Tejun Heo <tj@...nel.org>, Josef Bacik <josef@...icpanda.com>,
        Jens Axboe <axboe@...nel.dk>, cgroups@...r.kernel.org,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] blk-iocost: don't make all constants unsigned long long

On Tue, Dec 20, 2022 at 09:18:19PM +0100, Yann Droneaud <ydroneaud@...eya.com> wrote:
> +enum {
>  	/* switch iff the conditions are met for longer than this */
>  	AUTOP_CYCLE_NSEC	= 10LLU * NSEC_PER_SEC,
> +};

This looks gratuitous.

What about indivudial #defines with typed literals instead of the "lazy
splitting"?

Regards,
Michal

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)