linux-kernel - Re: [PATCH] media: v4l2-ctrls: Fix doc for v4l2_ctrl_request_hdl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1110c180e6586e213ea180920cbe6215b68a42be.camel@ndufresne.ca>
Date:   Thu, 22 Dec 2022 09:01:04 -0500
From:   Nicolas Dufresne <nicolas@...fresne.ca>
To:     Miaoqian Lin <linmq006@...il.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: v4l2-ctrls: Fix doc for
 v4l2_ctrl_request_hdl_find

Le jeudi 22 décembre 2022 à 15:56 +0400, Miaoqian Lin a écrit :
> We should call v4l2_ctrl_request_hdl_put() instead of
> v4l2_ctrl_request_put_hdl(). Fix the typo.
> 
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>

Reviewed-by: Nicolas Dufresne <nicolas.dufresne@...labora.com>

> ---
>  include/media/v4l2-ctrls.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h
> index e59d9a234631..7788eeb3e2bb 100644
> --- a/include/media/v4l2-ctrls.h
> +++ b/include/media/v4l2-ctrls.h
> @@ -1343,7 +1343,7 @@ void v4l2_ctrl_request_complete(struct media_request *req,
>   * @parent: The parent control handler ('priv' in media_request_object_find())
>   *
>   * This function finds the control handler in the request. It may return
> - * NULL if not found. When done, you must call v4l2_ctrl_request_put_hdl()
> + * NULL if not found. When done, you must call v4l2_ctrl_request_hdl_put()
>   * with the returned handler pointer.
>   *
>   * If the request is not in state VALIDATING or QUEUED, then this function