linux-kernel - Re: [PATCH printk v3 5/6] printk: introduce console_get_next_message() and console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bknva1jg.fsf@jogness.linutronix.de>
Date:   Thu, 22 Dec 2022 16:47:39 +0106
From:   John Ogness <john.ogness@...utronix.de>
To:     Petr Mladek <pmladek@...e.com>
Cc:     Sergey Senozhatsky <senozhatsky@...omium.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH printk v3 5/6] printk: introduce
 console_get_next_message() and console_message

On 2022-12-21, John Ogness <john.ogness@...utronix.de> wrote:
> +static bool console_emit_next_record(struct console *con, bool *handover, int cookie)
> +{
> +	bool is_extended = console_srcu_read_flags(con) & CON_EXTENDED;
> +	static char dropped_text[DROPPED_TEXT_MAX];
> +	static struct console_buffers cbufs;
> +	static struct console_message cmsg = {
> +		.cbufs = &cbufs,
> +	};

@cmsg should not be static. The whole point of the console_message
wrapper struct is so that it can sit on the stack.

John Ogness