linux-kernel - Re: [PATCH v2] ASoC: Intel: sof_nau8825: add variant with nau8318 amplifier.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <07538266-ea40-389e-9e68-054822121e0b@linux.intel.com>
Date:   Wed, 21 Dec 2022 18:27:14 -0600
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     Ajye Huang <ajye_huang@...pal.corp-partner.google.com>
Cc:     Libin Yang <libin.yang@...el.com>,
        Liam Girdwood <liam.r.girdwood@...ux.intel.com>,
        Cezary Rojewski <cezary.rojewski@...el.com>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        ye xingchen <ye.xingchen@....com.cn>,
        Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
        Takashi Iwai <tiwai@...e.com>, linux-kernel@...r.kernel.org,
        "balamurugan . c" <balamurugan.c@...el.com>,
        Mark Brown <broonie@...nel.org>,
        Muralidhar Reddy <muralidhar.reddy@...el.com>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        Akihiko Odaki <akihiko.odaki@...il.com>,
        David Lin <CTLIN0@...oton.com>, alsa-devel@...a-project.org,
        Bard Liao <yung-chuan.liao@...ux.intel.com>,
        Brent Lu <brent.lu@...el.com>, Yong Zhi <yong.zhi@...el.com>
Subject: Re: [PATCH v2] ASoC: Intel: sof_nau8825: add variant with nau8318
 amplifier.



On 12/21/22 17:30, Ajye Huang wrote:
> Hi Pierre
> 
> On Sat, Dec 17, 2022 at 1:37 AM Pierre-Louis Bossart
> <pierre-louis.bossart@...ux.intel.com> wrote:
> 
>>
>> Ok, thanks for the explanations.
>>
>> Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
> 
> Yesterday, I saw Arnd Bergmann sent this patch "ASoC: Intel:
> sof-nau8825: fix module alias overflow " for reducing the string to
> prevent over length,https://patchwork.kernel.org/project/alsa-devel/patch/20221221132515.2363276-1-arnd@kernel.org/.
> 
> so, I need to check with you, should my string need to change the
> format style with his, even the my string does not over length , from
> .drv_name = "adl_nau8318_nau8825" to .drv_name = "adl_nau8318_8825",
> align with his format style?

That would be more consistent indeed, no objections from me.