linux-kernel - Re: [PATCH 2/6] crypto: xts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMusb+QuNN9bgWSFZnd_VVVie7uBdBOsn=Z+_k5RLv5F1QtPqQ@mail.gmail.com>
Date:   Thu, 22 Dec 2022 17:41:18 +0100
From:   Vladis Dronov <vdronov@...hat.com>
To:     Eric Biggers <ebiggers@...nel.org>
Cc:     herbert@...dor.apana.org.au, davem@...emloft.net, nstange@...e.de,
        elliott@....com, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org, smueller@...onox.de
Subject: Re: [PATCH 2/6] crypto: xts - drop xts_check_key()

Hi,

On Thu, Dec 22, 2022 at 12:33 AM Eric Biggers <ebiggers@...nel.org> wrote:
>
> On Wed, Dec 21, 2022 at 11:41:07PM +0100, Vladis Dronov wrote:
> ...skip...
> > -     /* ensure that the AES and tweak key are not identical */
> > +     /* ensure that the AES and tweak key are not identical
> > +      * when in FIPS mode or the FORBID_WEAK_KEYS flag is set.
> > +      */
> >       if ((fips_enabled || (crypto_skcipher_get_flags(tfm) &
> >                             CRYPTO_TFM_REQ_FORBID_WEAK_KEYS)) &&
> >           !crypto_memneq(key, key + (keylen / 2), keylen / 2))
>
> Please use the kernel style for block comments:
>
>         /*
>          * Ensure that the AES and tweak key are not identical when in FIPS mode
>          * or the FORBID_WEAK_KEYS flag is set.
>          */

Thanks Eric, I will wait a bit for more review notes and I will resend
the patchset.

Best regards,
Vladis