linux-kernel - Re: [PATCH v4 3/4] arm64: dts: qcom: sdm845: align TLMM pin configuration with DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Dec 2022 10:53:15 -0800
From:   Doug Anderson <dianders@...omium.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Vinod Koul <vkoul@...nel.org>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Joel Selvaraj <joelselvaraj.oss@...il.com>,
        Marijn Suijten <marijn.suijten@...ainline.org>,
        Caleb Connolly <caleb@...nolly.tech>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 3/4] arm64: dts: qcom: sdm845: align TLMM pin
 configuration with DT schema

Hi,

On Thu, Dec 22, 2022 at 7:13 AM Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> DT schema expects TLMM pin configuration nodes to be named with
> '-state' suffix and their optional children with '-pins' suffix.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>
> ---
>
> Cc: Doug Anderson <dianders@...omium.org>
>
> Tested on Qualcomm RB3. Please kndly test a bit more on other devices.
> This should not have an functional impact.
>
> Changes since v3:
> 1. db845c: drop qup_uart3_default override and use qup_uart3_4pin
>    (Doug).
>
> Changes since v2:
> 1. Bring back UART6 4-pin bias/drive strength to DTSI.
>
> Changes since v1:
> 1. Address comments and implement conclusion with Doug.  Drop
>    default-pins/pinmux/mux/config nodes but instead add subnodes for
>    specific pins for UARTs.  This should match approach used for SC7180.
>
> v1: https://lore.kernel.org/linux-kernel/1b9dcca8-1abd-99a3-da12-a8763bf77f12@linaro.org/
> ---
>  arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi    | 397 ++++------
>  arch/arm64/boot/dts/qcom/sdm845-db845c.dts    |  93 +--
>  .../arm64/boot/dts/qcom/sdm845-lg-common.dtsi |  60 +-
>  arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts |   2 +-
>  arch/arm64/boot/dts/qcom/sdm845-mtp.dts       |  77 +-
>  .../boot/dts/qcom/sdm845-oneplus-common.dtsi  | 101 +--
>  .../boot/dts/qcom/sdm845-shift-axolotl.dts    | 150 ++--
>  .../dts/qcom/sdm845-sony-xperia-tama.dtsi     |   6 +-
>  .../qcom/sdm845-xiaomi-beryllium-common.dtsi  |  12 +-
>  .../boot/dts/qcom/sdm845-xiaomi-polaris.dts   |  21 +-
>  arch/arm64/boot/dts/qcom/sdm845.dtsi          | 689 ++++++++----------
>  .../boot/dts/qcom/sdm850-lenovo-yoga-c630.dts |  53 +-
>  .../boot/dts/qcom/sdm850-samsung-w737.dts     | 121 +--
>  13 files changed, 701 insertions(+), 1081 deletions(-)

Reviewed-by: Douglas Anderson <dianders@...omium.org>