linux-kernel - Re: [PATCH v2] arm64: dts: qcom: sm6350-lena: Flatten gpio-keys pinctrl state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <144d7b69-fb67-60dd-2c40-c004fbbba288@linaro.org>
Date:   Thu, 22 Dec 2022 23:01:38 +0100
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Marijn Suijten <marijn.suijten@...ainline.org>,
        phone-devel@...r.kernel.org
Cc:     ~postmarketos/upstreaming@...ts.sr.ht,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...ainline.org>,
        Martin Botka <martin.botka@...ainline.org>,
        Jami Kettunen <jami.kettunen@...ainline.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] arm64: dts: qcom: sm6350-lena: Flatten gpio-keys
 pinctrl state



On 22.12.2022 22:59, Marijn Suijten wrote:
> Pinctrl states typically collate multiple related pins.  In the case of
> gpio-keys there's no hardware-defined relation at all except all pins
> representing a key; and especially on Sony's lena board there's only one
> pin regardless. Flatten it similar to other boards [1].
> 
> As a drive-by fix, clean up the label string.
> 
> [1]: https://lore.kernel.org/linux-arm-msm/11174eb6-0a9d-7df1-6f06-da4010f76453@linaro.org/
> 
> Fixes: 2b8bbe985659 ("arm64: dts: qcom: sm6350-lena: Include pm6350 and configure buttons")
> Signed-off-by: Marijn Suijten <marijn.suijten@...ainline.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad
> 
> Changes since v1:
> 
> - Replace accidental semicolon in patch title with colon.
> 
> v1: https://lore.kernel.org/linux-arm-msm/20221222212634.298135-1-marijn.suijten@somainline.org/T/#u
> 
>  .../qcom/sm6350-sony-xperia-lena-pdx213.dts    | 18 ++++++++----------
>  1 file changed, 8 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
> index 94f77d376662..4916d0db5b47 100644
> --- a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
> +++ b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
> @@ -35,10 +35,10 @@ framebuffer: framebuffer@...00000 {
>  	gpio-keys {
>  		compatible = "gpio-keys";
>  		pinctrl-names = "default";
> -		pinctrl-0 = <&gpio_keys_state>;
> +		pinctrl-0 = <&vol_down_n>;
>  
>  		key-volume-down {
> -			label = "volume_down";
> +			label = "Volume Down";
>  			linux,code = <KEY_VOLUMEDOWN>;
>  			gpios = <&pm6350_gpios 2 GPIO_ACTIVE_LOW>;
>  		};
> @@ -305,14 +305,12 @@ touchscreen@48 {
>  };
>  
>  &pm6350_gpios {
> -	gpio_keys_state: gpio-keys-state {
> -		key-volume-down-pins {
> -			pins = "gpio2";
> -			function = PMIC_GPIO_FUNC_NORMAL;
> -			power-source = <0>;
> -			bias-disable;
> -			input-enable;
> -		};
> +	vol_down_n: vol-down-n-state {
> +		pins = "gpio2";
> +		function = PMIC_GPIO_FUNC_NORMAL;
> +		power-source = <0>;
> +		bias-disable;
> +		input-enable;
>  	};
>  };
>