linux-kernel - [PATCH v2] thunderbolt: Do not report errors if on-board retimers are found

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Dec 2022 20:22:46 -0800
From:   Utkarsh Patel <utkarsh.h.patel@...el.com>
To:     mika.westerberg@...ux.intel.com, michael.jamet@...el.com,
        andreas.noever@...il.com, YehezkelShB@...il.com,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Cc:     rajmohan.mani@...el.com, Utkarsh Patel <utkarsh.h.patel@...el.com>,
        stable@...r.kernel.org
Subject: [PATCH v2] thunderbolt: Do not report errors if on-board retimers are found

tb_retimer_scan() returns error even when on-board retimers are found.

Fixes: 1e56c88adecc ("thunderbolt: Runtime resume USB4 port when retimers are scanned")
Cc: stable@...r.kernel.org
Signed-off-by: Utkarsh Patel <utkarsh.h.patel@...el.com>
---
Changes in V2:
1. Removed extra line between the Fixes tag and signed-off.
2. Added the tag for stable tree.
---

 drivers/thunderbolt/retimer.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/thunderbolt/retimer.c b/drivers/thunderbolt/retimer.c
index 81252e31014a..6ebe7a2886ec 100644
--- a/drivers/thunderbolt/retimer.c
+++ b/drivers/thunderbolt/retimer.c
@@ -471,10 +471,9 @@ int tb_retimer_scan(struct tb_port *port, bool add)
 			break;
 	}
 
-	if (!last_idx) {
-		ret = 0;
+	ret = 0;
+	if (!last_idx)
 		goto out;
-	}
 
 	/* Add on-board retimers if they do not exist already */
 	for (i = 1; i <= last_idx; i++) {
-- 
2.25.1