linux-kernel - Re: [PATCH 01/13] blk-mq: avoid sleep in blk_mq_alloc_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221223053718.GA2676@lst.de>
Date:   Fri, 23 Dec 2022 06:37:18 +0100
From:   Christoph Hellwig <hch@....de>
To:     Kemeng Shi <shikemeng@...weicloud.com>
Cc:     axboe@...nel.dk, dwagner@...e.de, hare@...e.de,
        ming.lei@...hat.com, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, hch@....de, john.garry@...wei.com
Subject: Re: [PATCH 01/13] blk-mq: avoid sleep in blk_mq_alloc_request_hctx

On Fri, Dec 23, 2022 at 08:52:11PM +0800, Kemeng Shi wrote:
> +	if (WARN_ON_ONCE(((!flags) & (BLK_MQ_REQ_NOWAIT | BLK_MQ_REQ_RESERVED))))

This check does not make any sense.  I think what you want is

	if (WARN_ON_ONCE(!(flags & BLK_MQ_REQ_NOWAIT) ||
	    WARN_ON_ONCE(!(flags & BLK_MQ_REQ_RESERVED))))