linux-kernel - [PATCH] vfio_iommu_type1: increase the validity check of function parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20221223072418.3728-1-kunyu@nfschina.com>
Date:   Fri, 23 Dec 2022 15:24:18 +0800
From:   Li kunyu <kunyu@...china.com>
To:     alex.williamson@...hat.com, cohuck@...hat.com
Cc:     kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Li kunyu <kunyu@...china.com>
Subject: [PATCH] vfio_iommu_type1: increase the validity check of function parameters

Added validity check for count variable, return if count variable does 
not meet the execution condition (do not execute mutex_lock and 
mutex_unlock function).

Signed-off-by: Li kunyu <kunyu@...china.com>
---
 drivers/vfio/vfio_iommu_type1.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c
index 23c24fe98c00..9bdf96d932e4 100644
--- a/drivers/vfio/vfio_iommu_type1.c
+++ b/drivers/vfio/vfio_iommu_type1.c
@@ -3137,6 +3137,9 @@ static int vfio_iommu_type1_dma_rw(void *iommu_data, dma_addr_t user_iova,
 	int ret = 0;
 	size_t done;
 
+	if (count <= 0)
+		return ret;
+
 	mutex_lock(&iommu->lock);
 	while (count > 0) {
 		ret = vfio_iommu_type1_dma_rw_chunk(iommu, user_iova, data,
-- 
2.18.2