lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <18aad0e87316269b70c71d49692f2ef9a22fef62.camel@mediatek.com>
Date:   Fri, 23 Dec 2022 07:33:06 +0000
From:   Garmin Chang (張家銘) 
        <Garmin.Chang@...iatek.com>
To:     "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "sboyd@...nel.org" <sboyd@...nel.org>,
        "mturquette@...libre.com" <mturquette@...libre.com>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "richardcochran@...il.com" <richardcochran@...il.com>
CC:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        Project_Global_Chrome_Upstream_Group 
        <Project_Global_Chrome_Upstream_Group@...iatek.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v2 04/19] clk: mediatek: Add MT8188 peripheral clock
 support

On Thu, 2022-10-27 at 10:22 +0200, AngeloGioacchino Del Regno wrote:
> Il 24/10/22 11:42, Garmin.Chang ha scritto:
> > Add MT8188 peripheral clock controller which provides clock
> > gate control for ethernet/flashif/pcie/ssusb.
> > 
> > Signed-off-by: Garmin.Chang <Garmin.Chang@...iatek.com>
> 
> ..snip..
> 
> > +
> > +static const struct of_device_id of_match_clk_mt8188_peri_ao[] = {
> > +	{
> > +		.compatible = "mediatek,mt8188-pericfg_ao",
> > +		.data = &peri_ao_desc,
> > +	}, {
> > +		/* sentinel */
> > +	}
> > +};
> > +
> 
> Here and for all of the other drivers that you're introducing with
> this series...
> 
> please compress this array to one line per entry, like so:
> 
> static const struct of_device_id of_match_clk_mt8188_peri_ao[] = {
> 	{ .compatible = "mediatek,mt8188-pericfg_ao", .data =
> &peri_ao_desc },
> 	{ /* sentinel */ }
> };
> 
> Regards,
> Angelo
> 

  Ok, I will modify all drivers in the next version.

> Thanks,
> Best Regards,
> Garmin

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ