linux-kernel - Re: [PATCH] string.c: test *cmp for all possible 1-character strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <590d85c7-ef06-78d8-2459-d60739288c03@rasmusvillemoes.dk>
Date:   Fri, 23 Dec 2022 08:42:04 +0100
From:   Rasmus Villemoes <linux@...musvillemoes.dk>
To:     "Jason A. Donenfeld" <Jason@...c4.com>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Andy Shevchenko <andy@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] string.c: test *cmp for all possible 1-character strings

On 22/12/2022 16.15, Jason A. Donenfeld wrote:
> On Thu, Dec 22, 2022 at 03:05:06PM +0100, Rasmus Villemoes wrote:

>> This is only intended to help find other latent bugs and can/should be
>> ripped out again before v6.2, or perhaps moved to test_string.c in
>> some form, but for now I think it's worth doing unconditionally.
>>
> This probably belongs in some config-gated selftest file that can be
> compiled out, rather than running unconditionally on every boot, right?

I believe this was already answered in the last paragraph of the commit log.

Rasmus