linux-kernel - Re: [PATCH-next v2] blk-mq: cleanup unused methods: blk_mq_hw_sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y6VgY5hazTxxiyCt@infradead.org>
Date:   Fri, 23 Dec 2022 00:01:39 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     Zhong Jinghua <zhongjinghua@...wei.com>
Cc:     axboe@...nel.dk, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, yi.zhang@...wei.com,
        yukuai3@...wei.com
Subject: Re: [PATCH-next v2] blk-mq: cleanup unused methods:
 blk_mq_hw_sysfs_store

On Wed, Dec 21, 2022 at 04:34:21PM +0800, Zhong Jinghua wrote:
> We found that the blk_mq_hw_sysfs_store interface has no place to use.
> The object default_hw_ctx_attrs using blk_mq_hw_sysfs_ops only uses
> the show method and does not use the store method.
> 
> Since this patch:
> 4a46f05ebf99 ("blk-mq: move hctx and ctx counters from sysfs to debugfs")
> moved the store method to debugfs, the store method is not used anymore.
> 
> So let me do some tiny work to clean up unused code.

Please also remove the now unused store method from
struct blk_mq_hw_ctx_sysfs_entry.