linux-kernel - drivers/crypto/qat/qat_common/qat_compression.c:238:24-25: WARNING opportunity for kfree_sensitive/kvfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <7c94c126-55b7-7275-a592-3aaf4e59969f@inria.fr>
Date:   Fri, 23 Dec 2022 09:37:19 +0100 (CET)
From:   Julia Lawall <julia.lawall@...ia.fr>
To:     Giovanni Cabiddu <giovanni.cabiddu@...el.com>
cc:     Herbert Xu <herbert@...dor.apana.org.au>,
        Wojciech Ziemba <wojciech.ziemba@...el.com>,
        Adam Guerin <adam.guerin@...el.com>,
        linux-kernel@...r.kernel.org, oe-kbuild-all@...ts.linux.dev
Subject: drivers/crypto/qat/qat_common/qat_compression.c:238:24-25: WARNING
 opportunity for kfree_sensitive/kvfree_sensitive (memset at line 237)
 (fwd)

Hello,

This is referring to the function qat_free_dc_data, where there is a
memset 0 of data immediately followed by a kfree.  The use of
kfree_sensitive will ensure taht the memset is not optimized away.

julia

---------- Forwarded message ----------
Date: Wed, 21 Dec 2022 16:04:33 +0800
From: kernel test robot <lkp@...el.com>
To: oe-kbuild@...ts.linux.dev
Cc: lkp@...el.com, Julia Lawall <julia.lawall@...6.fr>
Subject: drivers/crypto/qat/qat_common/qat_compression.c:238:24-25: WARNING
    opportunity for kfree_sensitive/kvfree_sensitive (memset at line 237)

BCC: lkp@...el.com
CC: oe-kbuild-all@...ts.linux.dev
CC: linux-kernel@...r.kernel.org
TO: Giovanni Cabiddu <giovanni.cabiddu@...el.com>
CC: Herbert Xu <herbert@...dor.apana.org.au>
CC: Wojciech Ziemba <wojciech.ziemba@...el.com>
CC: Adam Guerin <adam.guerin@...el.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   b6bb9676f2165d518b35ba3bea5f1fcfc0d969bf
commit: 1198ae56c9a520384dcf53f01cd9adecd73751d0 crypto: qat - expose deflate through acomp api for QAT GEN2
date:   12 days ago
:::::: branch date: 17 hours ago
:::::: commit date: 12 days ago
config: loongarch-randconfig-c034-20221218
compiler: loongarch64-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Reported-by: Julia Lawall <julia.lawall@...6.fr>

cocci warnings: (new ones prefixed by >>)
>> drivers/crypto/qat/qat_common/qat_compression.c:238:24-25: WARNING opportunity for kfree_sensitive/kvfree_sensitive (memset at line 237)

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp
View attachment "config" of type "text/plain" (171641 bytes)