[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c4b75af0-76d7-7eb7-f0e5-53c7edd13304@collabora.com>
Date: Fri, 23 Dec 2022 10:26:55 +0100
From: AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>
To: Marijn Suijten <marijn.suijten@...ainline.org>,
phone-devel@...r.kernel.org
Cc: ~postmarketos/upstreaming@...ts.sr.ht,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...ainline.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
Martin Botka <martin.botka@...ainline.org>,
Jami Kettunen <jami.kettunen@...ainline.org>,
Bjorn Andersson <andersson@...nel.org>,
Andy Gross <agross@...nel.org>,
Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...nel.org>, linux-arm-msm@...r.kernel.org,
linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: qcom: dispcc-sm6125: Fix compatible string to match
bindings
Il 22/12/22 22:01, Marijn Suijten ha scritto:
> According to generic rules the SoC name should be first:
>
> arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dtb: clock-controller@...0000: compatible: 'oneOf' conditional failed, one must be fixed:
> 'qcom,dispcc-sm6125' does not match '^qcom,(apq|ipq|mdm|msm|qcm|qcs|sa|sc|sdm|sdx|sm)[0-9]+-.*$'
>
> And this is already reflected by the bindings submitted prior to the
> addition of this driver. Any DTS following these rules will end up with
> a non-probing driver because of this mismatch.
>
> Fixes: 6e87c8f07407 ("clk: qcom: Add display clock controller driver for SM6125")
> Signed-off-by: Marijn Suijten <marijn.suijten@...ainline.org>
Since there's no devicetree that is currently using the wrong compatible, you
are *not* breaking anything - hence fixing that issue without any regression.
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Powered by blists - more mailing lists