[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <bce86f79-9757-530b-b34e-1d2a71281e75@amd.com>
Date: Fri, 23 Dec 2022 15:15:25 +0530
From: Wyes Karny <wyes.karny@....com>
To: Perry Yuan <perry.yuan@....com>, rafael.j.wysocki@...el.com,
Mario.Limonciello@....com, ray.huang@....com,
viresh.kumar@...aro.org
Cc: Deepak.Sharma@....com, Nathan.Fontenot@....com,
Alexander.Deucher@....com, Shimmer.Huang@....com,
Xiaojian.Du@....com, Li.Meng@....com, linux-pm@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8 05/13] cpufreq: amd-pstate: optimize driver working
mode selection in amd_pstate_param()
On 12/19/2022 12:10 PM, Perry Yuan wrote:
--------------------->8-----------------------------
>
> +/**
> + * enum amd_pstate_mode - driver working mode of amd pstate
> + */
> +
> +enum amd_pstate_mode {
> + /** @AMD_PSTATE_DISABLE: Driver mode is disabled */
> + AMD_PSTATE_DISABLE = 0,
> +
> + /** @AMD_PSTATE_PASSIVE: Drier mode is passive mode */
> + AMD_PSTATE_PASSIVE = 1,
> +
> + /** @AMD_PSTATE_ACTIVE: Driver mode is active mode */
> + AMD_PSTATE_ACTIVE = 2,
> +
> + /** @AMD_PSTATE_GUIDE: Driver mode is guided mode */
> + AMD_PSTATE_GUIDE = 3,
> +
> + /** @AMD_PSTATE_MAX */
> + AMD_PSTATE_MAX = 4,
> +};
IMO the above enum is self explanatory we don't need to annotate.
what about below?
/**
* enum amd_pstate_mode - driver working mode
* All supported modes are explained in kernel-parameters.txt
*/
enum amd_pstate_mode {
AMD_PSTATE_DISABLE = 0,
AMD_PSTATE_PASSIVE,
AMD_PSTATE_ACTIVE,
AMD_PSTATE_MAX,
};
Plz remove GUIDED mode here because it allows user to pass "amd_pstate=guided"
in kernel cmdline. Therefore it breaks the driver flow without guided patches.
I can update the enum in my guided patch.
> +
> +static const char * const amd_pstate_mode_string[] = {
> + [AMD_PSTATE_DISABLE] = "disable",
> + [AMD_PSTATE_PASSIVE] = "passive",
> + [AMD_PSTATE_ACTIVE] = "active",
> + [AMD_PSTATE_GUIDE] = "guide",
> + NULL,
> +};
> +
> #endif /* _LINUX_AMD_PSTATE_H */
--
Thanks & Regards,
Wyes
Powered by blists - more mailing lists