[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e7960761-07c1-8cc7-60b3-1454ddb9317b@linaro.org>
Date: Fri, 23 Dec 2022 12:32:32 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: MD Danish Anwar <danishanwar@...com>,
"Andrew F. Davis" <afd@...com>, Tero Kristo <t-kristo@...com>,
Suman Anna <s-anna@...com>, Roger Quadros <rogerq@...nel.org>,
YueHaibing <yuehaibing@...wei.com>,
Vignesh Raghavendra <vigneshr@...com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Jakub Kicinski <kuba@...nel.org>,
Eric Dumazet <edumazet@...gle.com>,
"David S. Miller" <davem@...emloft.net>, andrew@...n.ch
Cc: nm@...com, ssantosh@...nel.org, srk@...com,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
netdev@...r.kernel.org, linux-omap@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 2/2] net: ti: icssg-prueth: Add ICSSG ethernet driver
On 23/12/2022 12:09, MD Danish Anwar wrote:
> From: Roger Quadros <rogerq@...com>
>
> This is the Ethernet driver for TI AM654 Silicon rev. 2
> with the ICSSG PRU Sub-system running dual-EMAC firmware.
>
(...)
> +
> +/* Memory Usage of : DMEM1
> + *
> + */
??? What's this?
> +
> +/* Memory Usage of : PA_STAT
> + *
> + */
Same question.
> +
> +/*Start of 32 bits PA_STAT counters*/
That's not a Linux coding style. Add spaces and make it readable.
Best regards,
Krzysztof
Powered by blists - more mailing lists