linux-kernel - Re: [PATCHv2 03/11] dmapool: use sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y6XXSDuqCC9EoxI6@infradead.org>
Date:   Fri, 23 Dec 2022 08:28:56 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     Keith Busch <kbusch@...a.com>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Matthew Wilcox <willy@...radead.org>,
        Tony Battersby <tonyb@...ernetics.com>,
        Kernel Team <kernel-team@...a.com>,
        Keith Busch <kbusch@...nel.org>
Subject: Re: [PATCHv2 03/11] dmapool: use sysfs_emit() instead of scnprintf()

> +		size += sysfs_emit_at(buf, size, "%-16s %4u %4zu %4zu %2u\n",
> +				      pool->name, blocks,
> +				      pages * (pool->allocation / pool->size),
> +				      pool->size, pages);

Did I mention that the sysfs_emit_at API sucks and should just take
size as a pointer argument an auto-increment?

Not really something we can change in this series, though.  So:

Reviewed-by: Christoph Hellwig <hch@....de>