[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y6XXy0h+bazIKwjC@infradead.org>
Date: Fri, 23 Dec 2022 08:31:07 -0800
From: Christoph Hellwig <hch@...radead.org>
To: Keith Busch <kbusch@...a.com>
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org,
Matthew Wilcox <willy@...radead.org>,
Tony Battersby <tonyb@...ernetics.com>,
Kernel Team <kernel-team@...a.com>,
Keith Busch <kbusch@...nel.org>
Subject: Re: [PATCHv2 06/11] dmapool: move debug code to own functions
> +static inline void pool_check_block(struct dma_pool *pool, void *retval,
> + unsigned int offset, gfp_t mem_flags)
> +{
> +#ifdef DMAPOOL_DEBUG
We normally keep the ifdef outside the function and provide stubs.
Extra points for keeping all the debug helpers in a single ifdef
block.
Powered by blists - more mailing lists