linux-kernel - Re: [PATCHv2 08/11] dmapool: consolidate page initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y6XY35c4nBLpLpJT@infradead.org>
Date:   Fri, 23 Dec 2022 08:35:43 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     Keith Busch <kbusch@...a.com>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Matthew Wilcox <willy@...radead.org>,
        Tony Battersby <tonyb@...ernetics.com>,
        Kernel Team <kernel-team@...a.com>,
        Keith Busch <kbusch@...nel.org>
Subject: Re: [PATCHv2 08/11] dmapool: consolidate page initialization

> +	page->in_use = 0;
> +	page->offset = 0;

This move makes total sense to me.

>  		return NULL;
>  
>  	spin_lock_irqsave(&pool->lock, flags);
> -
> -	list_add(&page->page_list, &pool->page_list);
> +	pool_initialise_page(pool, page);

.. but this now moves all of pool_initialise_page inside the
pool->lock critical section.  Is that really a good idea?