[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAMmci2VfvMoY9qZ5fjM7VkxBjTimx_Wps_5eMxS9GJsiTM9rkg@mail.gmail.com>
Date: Fri, 23 Dec 2022 10:02:10 +0800
From: ty <zonyitoo@...il.com>
To: Heiko Stübner <heiko@...ech.de>
Cc: Rob Herring <robh@...nel.org>, Peter Geis <pgwipeout@...il.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-rockchip@...ts.infradead.org, DHDAXCW <lasstp5011@...il.com>
Subject: Re: [PATCH v3 1/2] arm64: dts: rockchip: Add RK3566 LubanCat 1
Acknowledged. Fix will be in v8.
Heiko Stübner <heiko@...ech.de> 于2022年12月23日周五 03:10写道:
>
> Hi Rob,
>
> Am Donnerstag, 22. Dezember 2022, 18:25:04 CET schrieb Rob Herring:
> > On Wed, Dec 21, 2022 at 01:43:07PM +0800, Yuteng Zhong wrote:
> > > LubanCat 1 is a Rockchip RK3566 SBC based
> > > is developed by EmbedFire Electronics Co., Ltd.
> > > Mini Linux Card Type Cheap Computer Development Board
> > > It has the following characteristics:
> > > - MicroSD card slot, onboard eMMC flash memory
> > > - 1GbE Realtek RTL8211F Ethernet Transceiver
> > > - 1 USB Type-C port (power and USB2.0 OTG)
> > > - 1 USB 3.0 Host port
> > > - 3 USB 2.0 Host ports
> > > - 1 HDMI
> > > - 1 infrared receiver
> > > - 1 MIPI DSI
> > > - 1 MIPI CSI
> > > - 1 x 4-section headphone jack
> > > - Mini PCIe socket (USB or PCIe)
> > > - 1 SIM Card slot
> > > - 1 SYS LED and 1 PWR LED
> > > - 40-pin GPIO expansion header
> > >
> > > Signed-off-by: Yuteng Zhong <zonyitoo@...il.com>
> > > Signed-off-by: DHDAXCW <lasstp5011@...il.com>
> >
> > DHDAXCW is a legal name?
> >
> > The person sending the patch email should be last.
>
> We're on v7 already [0] and at least the Authorship + separate binding
> issue got fixed meanwhile - haven't looked at the whitespace issue there yet.
>
>
> Heiko
>
>
> [0] https://lore.kernel.org/all/Y6MlrbGKiIVc6tXt@VM-66-53-centos/
>
> > > ---
> > >
> > > Changed in V2:
> > > - Remove RNG node
> > > Changed in V3:
> > > - Modify all node names
> > >
> > > ---
> > > .../devicetree/bindings/arm/rockchip.yaml | 5 +
> >
> > Bindings should be separate patch.
> >
> > > arch/arm64/boot/dts/rockchip/Makefile | 1 +
> > > .../boot/dts/rockchip/rk3566-lubancat-1.dts | 600 ++++++++++++++++++
> >
> > Fix all the whitespace errors checkpatch.pl complains about.
> >
>
>
>
>
Powered by blists - more mailing lists