linux-kernel - Re: [PATCH 1/4] drm: panel: Add Himax HX8394 panel controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 23 Dec 2022 21:58:10 +0100
From:   Javier Martinez Canillas <javierm@...hat.com>
To:     Sam Ravnborg <sam@...nborg.org>
Cc:     linux-kernel@...r.kernel.org, Ondrej Jirman <megi@....cz>,
        Robert Mader <robert.mader@...teo.de>,
        Peter Robinson <pbrobinson@...il.com>,
        Kamil Trzciński <ayufan@...fan.eu>,
        Martijn Braam <martijn@...xit.nl>,
        Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...il.com>,
        Thierry Reding <thierry.reding@...il.com>,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 1/4] drm: panel: Add Himax HX8394 panel controller driver

Hello Sam,

On 12/23/22 10:17, Sam Ravnborg wrote:
> Hi Javier.
> 
> On Thu, Dec 22, 2022 at 11:38:27PM +0100, Javier Martinez Canillas wrote:
>> From: Kamil Trzciński <ayufan@...fan.eu>
>>
>> The driver is for panels based on the Himax HX8394 controller, such as the
>> HannStar HSD060BHW4 720x1440 TFT LCD panel that uses a MIPI-DSI interface.
> 
> A few comments/nitpicks in the following.
> I have been away for a while, and paged out most of my panel knowledge,
> so read it all with that in mind.
>

Thanks a lot for your feedback! I agree with your comments and will address
those in the next iteration.
 
> In general - very nicely written driver.
> 
> 	Sam
> 

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat