linux-kernel - Re: [PATCH v2] tty: serial: dz: convert atomic_* to refcount_* APIs for irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 24 Dec 2022 09:37:43 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Deepak R Varma <drv@...lo.com>
Cc:     "Maciej W. Rozycki" <macro@...am.me.uk>,
        Jiri Slaby <jirislaby@...nel.org>,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
        Saurabh Singh Sengar <ssengar@...rosoft.com>,
        Praveen Kumar <kumarpraveen@...ux.microsoft.com>
Subject: Re: [PATCH v2] tty: serial: dz: convert atomic_* to refcount_* APIs
 for irq_guard

On Sat, Dec 24, 2022 at 01:47:12PM +0530, Deepak R Varma wrote:
> The refcount_* APIs are designed to address known issues with the
> atomic_t APIs for reference counting. They provide following distinct
> advantages:
>    - protect the reference counters from overflow/underflow
>    - avoid use-after-free errors
>    - provide improved memory ordering guarantee schemes
>    - neater and safer.
> Hence, replace the atomic_* APIs by their equivalent refcount_t
> API functions.
> 
> This patch proposal address the following warnings generated by
> the atomic_as_refcounter.cocci coccinelle script
> atomic_add_return(-1, ...)
> 
> Signed-off-by: Deepak R Varma <drv@...lo.com>
> ---

This depends on the previous patch you sent, so why wasn't this a patch
series?  Always send patches as a series, otherwise I would have
attempted to apply this one first and it would have failed.  You will
recieve 0-day reports about that happening over the next few days as our
testing infrastructure will also be confused.

Please fix and resend all changes you wish to have done to this driver
together.

thanks,

greg k-h