linux-kernel - Re: [PATCH] pktcdvd: remove driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221224133425.vlcxbaaynihiom4a@pali>
Date:   Sat, 24 Dec 2022 14:34:25 +0100
From:   Pali Rohár <pali@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Jens Axboe <axboe@...nel.dk>, linux-kernel@...r.kernel.org,
        Christoph Hellwig <hch@...radead.org>,
        Thomas Maier <balagi@...tmail.de>, linux-block@...r.kernel.org
Subject: Re: [PATCH] pktcdvd: remove driver.

On Saturday 24 December 2022 13:24:39 Greg Kroah-Hartman wrote:
> On Sat, Dec 24, 2022 at 11:11:39AM +0100, Pali Rohár wrote:
> > On Saturday 24 December 2022 11:03:27 Greg Kroah-Hartman wrote:
> > > On Sat, Dec 24, 2022 at 10:53:53AM +0100, Pali Rohár wrote:
> > > > On Friday 02 December 2022 19:27:58 Greg Kroah-Hartman wrote:
> > > > > Way back in 2016 in commit 5a8b187c61e9 ("pktcdvd: mark as unmaintained
> > > > > and deprecated") this driver was marked as "will be removed soon".  5
> > > > > years seems long enough to have it stick around after that, so finally
> > > > > remove the thing now.
> > > > 
> > > > Why to remove? This driver is still widely used, userspace in active
> > > > maintenance and in last two years userspace software received more fixes
> > > > for CD-RW support and pktcdvd.
> > > 
> > > It was marked as "please remove" back in 2016, why wasn't that changed
> > > if people were actually using this?
> > 
> > And how should I know it if I was informed about it just today?
> 
> Using the "Why was I not informed?" defense isn't usually the best way
> to discuss things when we have 800+ maintainers and 4000+ developers
> here :)

And asking question back is not the best way too.

> > > > Just now community person informed me that somebody is going to remove
> > > > kernel support.
> > > 
> > > Isn't there better ways to support the hardware needed than this driver?
> > 
> > Is there any other driver in kernel which provide block layer for it?
> > I do not know about any other.
> 
> What about the venerable sg.c driver (enabled with CONFIG_CHR_DEV_SG)?
> Does that not work properly for your specific hardware?

No, it is not a mountable rw block device suitable for CD-RW and DVD-RW.

> Anyway, have a nice holiday!
> 
> greg k-h