linux-kernel - fs/ntfs3/frecord.c:1648 ni_fname_name() warn: inconsistent indenting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202212250724.gNIg7quC-lkp@intel.com>
Date:   Sun, 25 Dec 2022 07:41:17 +0800
From:   kernel test robot <lkp@...el.com>
To:     Thomas Kühnel <thomas.kuehnel@....de>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Konstantin Komarov <almaz.alexandrovich@...agon-software.com>,
        Nicolas Schier <n.schier@....de>
Subject: fs/ntfs3/frecord.c:1648 ni_fname_name() warn: inconsistent indenting

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   72a85e2b0a1e1e6fb4ee51ae902730212b2de25c
commit: 90c1cd540cc81023c5826891f3793ea159c4562e fs/ntfs3: Fix endian conversion in ni_fname_name
date:   6 weeks ago
config: parisc-randconfig-m031-20221219
compiler: hppa-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

New smatch warnings:
fs/ntfs3/frecord.c:1648 ni_fname_name() warn: inconsistent indenting

Old smatch warnings:
fs/ntfs3/frecord.c:482 ni_ins_new_attr() error: we previously assumed 'le' could be null (see line 467)
fs/ntfs3/frecord.c:1489 ni_insert_nonresident() warn: potential memory corrupting cast 8 vs 2 bytes
fs/ntfs3/frecord.c:2632 ni_read_frame() warn: ignoring unreachable code.

vim +1648 fs/ntfs3/frecord.c

  1635	
  1636	/* ni_fname_name
  1637	 *
  1638	 * Return: File name attribute by its value.
  1639	 */
  1640	struct ATTR_FILE_NAME *ni_fname_name(struct ntfs_inode *ni,
  1641					     const struct cpu_str *uni,
  1642					     const struct MFT_REF *home_dir,
  1643					     struct mft_inode **mi,
  1644					     struct ATTR_LIST_ENTRY **le)
  1645	{
  1646		struct ATTRIB *attr = NULL;
  1647		struct ATTR_FILE_NAME *fname;
> 1648	       struct le_str *fns;
  1649	
  1650		if (le)
  1651			*le = NULL;
  1652	
  1653		/* Enumerate all names. */
  1654	next:
  1655		attr = ni_find_attr(ni, attr, le, ATTR_NAME, NULL, 0, NULL, mi);
  1656		if (!attr)
  1657			return NULL;
  1658	
  1659		fname = resident_data_ex(attr, SIZEOF_ATTRIBUTE_FILENAME);
  1660		if (!fname)
  1661			goto next;
  1662	
  1663		if (home_dir && memcmp(home_dir, &fname->home, sizeof(*home_dir)))
  1664			goto next;
  1665	
  1666		if (!uni)
  1667			return fname;
  1668	
  1669		if (uni->len != fname->name_len)
  1670			goto next;
  1671	
  1672		fns = (struct le_str *)&fname->name_len;
  1673		if (ntfs_cmp_names(uni->name, uni->len, fns->name, fns->len, NULL,
  1674				       false))
  1675			goto next;
  1676	
  1677		return fname;
  1678	}
  1679	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (134616 bytes)