linux-kernel - Re: [PATCH v2 1/2] .gitinogre: update the command to check tracked files being ignored

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72=jDGX+8XobCTFs1-ut38cxQd0m7kEMg7U1Vn+NxtMTwA@mail.gmail.com>
Date:   Sun, 25 Dec 2022 19:37:00 +0100
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Masahiro Yamada <masahiroy@...nel.org>
Cc:     linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
        Alex Gaynor <alex.gaynor@...il.com>, Andrew Davis <afd@...com>,
        Kees Cook <keescook@...omium.org>,
        Miguel Ojeda <ojeda@...nel.org>,
        Wedson Almeida Filho <wedsonaf@...gle.com>
Subject: Re: [PATCH v2 1/2] .gitinogre: update the command to check tracked
 files being ignored

On Sat, Dec 24, 2022 at 4:51 PM Masahiro Yamada <masahiroy@...nel.org> wrote:
>
> The -c was implied for older git versions, but we need to make it
> explicit now.

Perhaps add a `Link:` to Git's commit b338e9f66873 ("ls-files: error
out on -i unless -o or -c are specified")

    https://git.kernel.org/pub/scm/git/git.git/commit/?id=b338e9f668737e08201c990450b8c3d744f63162

> We never know what are locally added to $GIT_DIR/info/exclude or
> $XDG_CONFIG_HOME/git/ignore.

Perhaps we could say "global exclusion file" instead (since it could
be the one from `core.excludesFile` too).

> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>

By the way, in the commit title: "gitinogre" -> "gitignore"

Reviewed-by: Miguel Ojeda <ojeda@...nel.org>

Cheers,
Miguel