linux-kernel - Re: [PATCH 26/26] arm64: dts: qcom: c630: set venus firmware name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAA8EJpqD6pvZjXa4_cQ=02o_Ns94LAJ3n-S2Q8LjfqOySgHHfA@mail.gmail.com>
Date:   Sun, 25 Dec 2022 17:22:18 +0200
From:   Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To:     Steev Klimaszewski <steev@...i.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 26/26] arm64: dts: qcom: c630: set venus firmware name

On Sun, 25 Dec 2022 at 06:08, Steev Klimaszewski <steev@...i.org> wrote:
>
> The Lenovo Yoga C630 can't use the generic venus firmware that is in the
> linux-firmware repository, and needs a signed one.  This file is
> qcvss850.mbn from the Windows partition and needs to be copied manually.
>
> Signed-off-by: Steev Klimaszewski <steev@...i.org>
> ---
>  arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> index 7e80e2950f8d..78a14f899df9 100644
> --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> @@ -801,6 +801,7 @@ &usb_2_qmpphy {
>  };
>
>  &venus {
> +       firmware-name = "qcom/venus-5.2/qcvss850.mbn";

Please follow the established convention (see e.g. the x13s laptop firmware).
It should be "qcom/sdm850/LENOVO/81JL/qcvss850.mbn" (or
qcom/sdm845/LENOVO/....).

>         status = "okay";
>  };
>
> --
> 2.35.1
>


-- 
With best wishes
Dmitry