linux-kernel - Re: [PATCH v2 3/4] mm: mlock: update the interface to use folios

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y6lYIfVAf+EZa/Lb@casper.infradead.org>
Date:   Mon, 26 Dec 2022 08:15:29 +0000
From:   Matthew Wilcox <willy@...radead.org>
To:     Lorenzo Stoakes <lstoakes@...il.com>
Cc:     linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, Hugh Dickins <hughd@...gle.com>,
        Vlastimil Babka <vbabka@...e.cz>,
        Liam Howlett <liam.howlett@...cle.com>,
        William Kucharski <william.kucharski@...cle.com>,
        Christian Brauner <brauner@...nel.org>,
        Jonathan Corbet <corbet@....net>,
        Mike Rapoport <rppt@...nel.org>,
        Joel Fernandes <joel@...lfernandes.org>
Subject: Re: [PATCH v2 3/4] mm: mlock: update the interface to use folios

On Mon, Dec 26, 2022 at 07:08:46AM +0000, Lorenzo Stoakes wrote:
>  			goto out;
> -		page = pmd_page(*pmd);
> +		folio = page_folio((struct page *)pmd_page(*pmd));

I do not like this fix.  Better to fix m68k to:

#define pmd_page(pmd)	(struct page *)NULL