linux-kernel - [PATCH v1] seccomp: Fix the comment for seccomp_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20221226125317.14465-1-haytok@amazon.co.jp>
Date:   Mon, 26 Dec 2022 21:53:18 +0900
From:   Hayato Kiwata <haytok@...zon.co.jp>
To:     Kees Cook <keescook@...omium.org>,
        Andy Lutomirski <luto@...capital.net>,
        Will Drewry <wad@...omium.org>
CC:     <linux-kernel@...r.kernel.org>,
        Hayato Kiwata <haytok@...zon.co.jp>,
        Hayato Kiwata <simplelpmis6@...il.com>,
        Kuniyuki Iwashima <kuniyu@...zon.com>
Subject: [PATCH v1] seccomp: Fix the comment for seccomp_check_filter().

The comment of the seccomp_check_filter() contains a removed function,
seccomp_bpf_load(). This comment needs to be corrected as it may be
misleading to future readers.

seccomp_bpf_load() was removed in the commit bd4cf0ed331a ("net: filter:
rework/optimize internal BPF interpreter's instruction set"). Previously,
seccomp_bpf_load() was used to create an object of struct seccomp_data.
However, this is done inside populate_seccomp_data() now.

Signed-off-by: Hayato Kiwata <haytok@...zon.co.jp>
---
 kernel/seccomp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/seccomp.c b/kernel/seccomp.c
index d653d8426de9..3a93595f4989 100644
--- a/kernel/seccomp.c
+++ b/kernel/seccomp.c
@@ -167,7 +167,7 @@ static void populate_seccomp_data(struct seccomp_data *sd)
  *
  * Takes a previously checked filter (by bpf_check_classic) and
  * redirects all filter code that loads struct sk_buff data
- * and related data through seccomp_bpf_load.  It also
+ * and related data through populate_seccomp_data().  It also
  * enforces length and alignment checking of those loads.
  *
  * Returns 0 if the rule set is legal or -EINVAL if not.
-- 
2.35.1