linux-kernel - Re: [PATCH v9 1/4] crypto: ccp - Name -1 return value as SEV_RET_NO_FW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9bffccfa-ed01-e1a0-8619-75670a340167@amd.com>
Date:   Mon, 26 Dec 2022 08:26:00 -0600
From:   Tom Lendacky <thomas.lendacky@....com>
To:     Borislav Petkov <bp@...en8.de>,
        Dionna Glaze <dionnaglaze@...gle.com>,
        Herbert Xu <herbert@...dor.apana.org.au>
Cc:     linux-kernel@...r.kernel.org, x86@...nel.org,
        Peter Gonda <pgonda@...gle.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Joerg Roedel <jroedel@...e.de>, Ingo Molnar <mingo@...hat.com>,
        Andy Lutomirsky <luto@...nel.org>,
        John Allen <john.allen@....com>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH v9 1/4] crypto: ccp - Name -1 return value as
 SEV_RET_NO_FW_CALL

On 12/22/22 09:31, Borislav Petkov wrote:
> On Wed, Dec 07, 2022 at 01:02:07AM +0000, Dionna Glaze wrote:
>> From: Peter Gonda <pgonda@...gle.com>
>>
>> The PSP can return a "firmware error" code of -1 in circumstances where
>> the PSP is not actually called. To make this protocol unambiguous, the
>> value is named SEV_RET_NO_FW_CALL.
>>
>> Cc: Thomas Lendacky <Thomas.Lendacky@....com>
>> Cc: Paolo Bonzini <pbonzini@...hat.com>
>> Cc: Joerg Roedel <jroedel@...e.de>
>> Cc: Ingo Molnar <mingo@...hat.com>
>> Cc: Andy Lutomirsky <luto@...nel.org>
>> Cc: John Allen <john.allen@....com>
>> Cc: Herbert Xu <herbert@...dor.apana.org.au>
>> Cc: "David S. Miller" <davem@...emloft.net>
>> Cc: Borislav Petkov <bp@...en8.de>
>>
>> Signed-off-by: Peter Gonda <pgonda@...gle.com>
>> Signed-off-by: Dionna Glaze <dionnaglaze@...gle.com>
>> ---
>>   Documentation/virt/coco/sev-guest.rst |  2 +-
>>   drivers/crypto/ccp/sev-dev.c          | 22 ++++++++++++++--------
>>   include/uapi/linux/psp-sev.h          |  7 +++++++
>>   3 files changed, 22 insertions(+), 9 deletions(-)
> 
> Looks good, did some minor touch ups ontop, see below.
> 
> @Tom: Ack/Rev-by?

Acked-by: Tom Lendacky <thomas.lendacky@....com>

> 
> @Herbert: ok to carry this through tip?
> 
> Thx.
>