linux-kernel - Re: [PATCH v3] blk-throtl: Introduce sync and async queues for blk-throtl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202212262348.NpspIpjU-lkp@intel.com>
Date:   Mon, 26 Dec 2022 23:24:26 +0800
From:   kernel test robot <lkp@...el.com>
To:     Jinke Han <hanjinke.666@...edance.com>, tj@...nel.org,
        josef@...icpanda.com, axboe@...nel.dk
Cc:     oe-kbuild-all@...ts.linux.dev, cgroups@...r.kernel.org,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        yinxin.x@...edance.com, Jinke Han <hanjinke.666@...edance.com>
Subject: Re: [PATCH v3] blk-throtl: Introduce sync and async queues for
 blk-throtl

Hi Jinke,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on axboe-block/for-next]
[also build test WARNING on linus/master v6.2-rc1 next-20221226]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jinke-Han/blk-throtl-Introduce-sync-and-async-queues-for-blk-throtl/20221226-210601
base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
patch link:    https://lore.kernel.org/r/20221226130505.7186-1-hanjinke.666%40bytedance.com
patch subject: [PATCH v3] blk-throtl: Introduce sync and async queues for blk-throtl
config: x86_64-rhel-8.3-func
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/bb8c9fad48016fc6e9e63ac695f445b6814c4703
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Jinke-Han/blk-throtl-Introduce-sync-and-async-queues-for-blk-throtl/20221226-210601
        git checkout bb8c9fad48016fc6e9e63ac695f445b6814c4703
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 olddefconfig
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> block/blk-throttle.c:355: warning: expecting prototype for throtl_qnode_bio_pop(). Prototype was for throtl_qnode_bio_list_pop() instead


vim +355 block/blk-throttle.c

   345	
   346	/**
   347	 * throtl_qnode_bio_pop: pop a bio from sync/async queue
   348	 * @qn: the qnode to pop a bio from
   349	 *
   350	 * For write io qn, the target queue to pop was determined by the disp_sync_cnt.
   351	 * Try to pop bio from target queue, fetch the bio and return it when it is not
   352	 * empty. If the target queue empty, pop bio from another queue instead.
   353	 */
   354	static inline struct bio *throtl_qnode_bio_list_pop(struct throtl_qnode *qn)
 > 355	{
   356		struct bio *bio;
   357		int from = SYNC;
   358	
   359		if (qn->disp_sync_cnt == THROTL_SYNC_FACTOR)
   360			from = ASYNC;
   361	
   362		bio = bio_list_pop(&qn->bios[from]);
   363		if (!bio) {
   364			from = 1 - from;
   365			bio = bio_list_pop(&qn->bios[from]);
   366		}
   367	
   368		if ((qn->disp_sync_cnt < THROTL_SYNC_FACTOR) &&
   369			(from == SYNC))
   370			qn->disp_sync_cnt++;
   371		else
   372			qn->disp_sync_cnt = 0;
   373	
   374		return bio;
   375	}
   376	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (171691 bytes)